(Instance/Azjol-Nerub): Anub'Arak should remove debuffs on submerging

[YggdrasilWotLK]

Current Behaviour

Currently, he's not dropping his debuffs when he starts to cast submerge. Consequences of this includes that if he dies while submerged (due to DOTs), he becomes unlootable.

Expected Blizzlike Behaviour

He should drop his debuffs on starting to cast submerge.

Source

https://www.youtube.com/watch?v=mTlJn8oGTJ0 re 06:40

Steps to reproduce the problem

1. Go to Anub'Arak in Azjol-Nerub
2. DOT him up
3. Get him to 75% and watch him submerge with DOTs active

Extra Notes

I'm not too familiar with how PRs and such work but I imagine the fix could be changing this part in boss_anubarak.cpp (https://github.com/metallinos2/azerothcore-wotlk/commit/64802191a93c8a8eb113025b96a42d85a27751c8)

                    if (me->HealthBelowPct(eventId*25))
                    {
                        Talk(SAY_SUBMERGE);
                        me->RemoveAllAuras(); *new line to remove auras 
                        me->CastSpell(me, SPELL_IMPALE_PERIODIC, true);
                        me->CastSpell(me, SPELL_SUBMERGE, false);

AC rev. hash/commit

20ff8df

Operating system

Ubuntu 20.04

Custom changes or Modules

ELUNA module

[sogladev]

On wrath classic he did remove all dots at the start of his burrow. He remained targettable for ~1 second, so you could re apply a dot.

burrow in TOGC for reference does remove auras

• azerothcore-wotlk/src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheCrusader/boss_anubarak_trial.cpp

  Line 316 in b055faf

  me->RemoveAllAuras();

unkillable can be done with bossAI

void DamageTaken(Unit* attacker, uint32& damage, DamageEffectType damageEffectType, SpellSchoolMask spellSchoolMask) override
    {
        if (me->HasAuras(SPELL_SUBMERGE);)
        {
            if (damage >= me->GetHealth())
            {
                damage = me->GetHealth() - 1;
            }
        }
        BossAI::DamageTaken(attacker, damage, damageEffectType, spellSchoolMask);
    }

[heyitsbench]

Anub'Arak uses this spell to clear his debuffs on submerge.

EDIT: Found in sniffs for both Azjol-Nerub and Trial of the Grand Crusader.