Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] sra-macie-org-main-ssm.json includes a pSRAStagingS3BucketName parameter that should be read from SSM parameters #223

Open
julian-price opened this issue Jun 19, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@julian-price
Copy link

Describe the bug

When deploying Macie (via the CfCT in my case, but the same issue should happen via CloudFormation CLI), the SSM JSON parameters file (sra-macie-org-main-ssm.json) includes a value that should be read from it's SSM parameter and therefore not be included in the JSON file.

To Reproduce

Steps to reproduce the behavior:

  1. Copy the sra-macie-org-main-ssm.json file from the SRA solution to the parameters directory in the custom-control-tower-configuration CodeCommit repo.
  2. Copy the sra-macie-org-main-ssm.yaml file from the SRA solution to the templates directory in the custom-control-tower-configuration CodeCommit repo.
  3. Add an entry to the manifest.yaml file to deploy the solution.
  4. Commit changes to kick off the pipeline
  5. The Macie org solution fails to deploy with an error
Parameter pSRAStagingS3BucketName should either have input value or default value

Expected behavior

The Macie org solution deploys without errors.

Deployment Environment (please complete the following information)

  • Deployment Framework: Customizations for Control Tower
  • Deployment Framework Version: CfCT v2.7.1 and SRA examples v3.1.0

Additional context

Removing the parameter from the JSON file allows the deployment to proceed successfully.

@julian-price julian-price added the bug Something isn't working label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant