-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scoping in the Composite context #3799
base: main
Are you sure you want to change the base?
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
@diegohaz any quick way to create a starter codesandbox using this PR's version? |
I'm not sure. It used to be generated automatically, but it stopped working suddenly a while ago. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DaniGuardiola!
The changes make sense and align with how other composite components are implemented. It would be nice to have a simple example of what you're trying to do on WordPress that triggered this issue.
Thanks @diegohaz, here's the example: https://stackblitz.com/edit/vitejs-vite-ihjzqp?file=src%2FApp.tsx This should work with this PR's version. |
Thanks! Would you mind turning that into an example with tests (without a readme.md file) for this PR? |
@diegohaz of course, I actually already have that locally since I needed to test it, I just didn't push it haha. Didn't realize you were referring to that. I will push it in a bit. |
…iakit/ariakit into fix/composite-context-scoping
@diegohaz pushed, let me know if the test is adequate. Here's a demo of it: Kapture.2024-05-20.at.23.08.36.mp4 |
Fixes #3768