Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(image): parse image.inspect.Created field only for non-empty values #6948

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix(image): parse image.inspect.Created field only for non-empty values #6948

merged 1 commit into from
Jun 19, 2024

Conversation

DmitriyLewen
Copy link
Contributor

Description

Created field can be empty - https://github.com/moby/moby/blob/8e96db1c328d0467b015768e42a62c0f834970bb/api/types/types.go#L76-L77
We don't need to parse this empty field to avoid errors.

Error example - #6944

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Jun 17, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review June 17, 2024 05:01
@knqyf263 knqyf263 added this pull request to the merge queue Jun 19, 2024
Merged via the queue into aquasecurity:main with commit 0af5730 Jun 19, 2024
12 checks passed
@aqua-bot aqua-bot mentioned this pull request Jun 19, 2024
Open
@DmitriyLewen DmitriyLewen deleted the fix-image/empty-created-field branch June 19, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees

@DmitriyLewen DmitriyLewen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Images with deleted timestamps break with Docker 26
2 participants
@DmitriyLewen @knqyf263