TypeError: Cannot convert undefined or null to object

[honzajavorek]

Sometimes gavel2html fails to render the diff for some reason. We're able to see this when using gavel2html internally in apiary.io, but we don't know (yet) what's the exact input to trigger this.

gavelhtml: Internal error. 
 [TypeError: Cannot convert undefined or null to object 
  at Function.keys (<anonymous>:null:null) 
  at HeadersResultConverter._getLines (/app/node_modules/gavel2html/lib/headers-result-converter.js:27:37) 
  at HeadersResultConverter.getHtmlPrivate (/app/node_modules/gavel2html/lib/headers-result-converter.js:71:18) 
  at HeadersResultConverter.Converter.getHtml (/app/node_modules/gavel2html/lib/converter.js:46:17) 
  at Gavel2Html.getHtml (/app/node_modules/gavel2html/lib/gavel2html.js:61:26) 
  ...
]

[honzajavorek]

It seems like if this line

gavel2html/src/headers-result-converter.coffee

Line 27 in 99897d7

for k, v of dataRealWithExpected then do (k, v) =>

blew up because dataRealWithExpected is not an object but undefined.

for k, v of dataRealWithExpected then do (k, v) =>
  console.log(k, v)

translates to

var k, v;

for (k in dataRealWithExpected) {
  v = dataRealWithExpected[k];
  ((k, v) => {
    return console.log(k, v);
  })(k, v);
}

Where I believe the for ... in statement might blow up with a similar error if it got to iterate over undefined (hunch, not verified).

[honzajavorek]

Surprisingly, iterating over undefined like this doesn't trigger any error:

> const obj = undefined;
> for (k in obj) { console.log(k); }
undefined

Accessing a property throws a different errorr:

> obj['foo']
TypeError: Cannot read property 'foo' of undefined

But I got completely the same error if calling Object.keys() on undefined:

> Object.keys(obj)
TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)

That means the line numbers are probably off and the problem raises in these two lines:

gavel2html/src/headers-result-converter.coffee

Lines 16 to 17 in 99897d7

	lowercasedExpectedKeys = Object.keys(@dataExpected).map (s) -> s.toLowerCase()
	lowercasedRealKeys = Object.keys(@dataReal).map (s) -> s.toLowerCase()

Both lines are a product of @getFromString:

gavel2html/src/headers-result-converter.coffee

Lines 13 to 14 in 99897d7

	@dataReal = @getFromString @dataReal
	@dataExpected = @getFromString @dataExpected

There is a path in code which can result in the data not being an object:

gavel2html/src/headers-result-converter.coffee

Lines 66 to 67 in 99897d7

	if not header or typeof header isnt 'string'
	return header

However, subsequent code doesn't seem to count with that option.

[honzajavorek]

So the issue is that headers are set to undefined instead of {}. There are two steps to mitigation of this issue:

• We should check what exactly we're sending to gavel2html on apiary.io side
• gavel2html should be better in validating inputs and throwing when something's wrong so the code calling it can somehow react to this situation - instead of rendering HTML with Internal validator error and performing console.error()

[madhurab20]

convert undefined or null to object
at Function.keys ()
at DynamicListingComponent.push../src/app/shared/dynamic-