Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architecture #16

Open
honzajavorek opened this issue Jan 10, 2019 · 4 comments
Open

Architecture #16

honzajavorek opened this issue Jan 10, 2019 · 4 comments

Comments

@honzajavorek
Copy link
Contributor

This library should get rewritten from scratch.


  • Version 0.2.0-unstable.1 used by apiary.io works, but isn't in git, we do not have it's CoffeeScript code anywhere, npm contains only compiled JS.
  • Current version from git has regression bugs, algorithm to render JSON is changed for some reason and it doesn't work correctly.
  • The library is unmaintainable, the code is undercommented and there are no docs (not even about the public interface)
  • The behavior isn't specified, there are very little tests, mostly some regressions

Update: The gavel2html branch for 0.2.0-unstable.1, which is used by apiary.io, has been recovered from @kuba-kubula's backup disk. It is now pushed to GitHub under kubula/customize_json_converter_html branch name.

@artem-zakharchenko
Copy link
Contributor

Can somebody verify which of the next branches are actually up-to-date with what is used in the core app?

  1. kubula/customize_json_converter_html
  2. kubula/customize_headers_converter

Commits diff states it's the first one, but I would like somebody to verify that.

@kuba-kubula
Copy link
Member

kuba-kubula commented Jun 17, 2019

@artem-zakharchenko @honzajavorek

From what I see in branches and history of git:

  1. there's tag v0.1.0 at commit 1f0d32c
  2. there's a branch based on that ^^^ tag, named kubula/customize_headers_converter (with 5 commits, last is 906cde7)
  3. there's a branch based on that ^^^ branch's last commit, named kubula/customize_json_converter_html (with 7 additional commits, last is dd4d441 with commit message bump to 0.2.0-unstable – although the change to version in the package.json file was a 0.2.0-unstable.1 version)

I can verify that there's that version published to npm registry, using command:

$ npm view [email protected] gitHead
dd4d441efa04d948ba2009a83f70910ba3871c51

That ^^^ is the same hash as the last commit in branch kubula/customize_json_converter_html

─ v0.1.0
└ kubula/customize_headers_converter
  └ kubula/customize_json_converter_html

@artem-zakharchenko
Copy link
Contributor

#17 ensures current master equals to the @kuba-kubula's feature branch currently used in the core app. #18 published that master to npm.

@artem-zakharchenko
Copy link
Contributor

Published the actually used package version to NPM. Version: 1.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants