Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature which requires hooks handler to react to SIGTERM #67

Open
honzajavorek opened this issue Jun 6, 2019 · 0 comments
Open

Comments

@honzajavorek
Copy link
Contributor

honzajavorek commented Jun 6, 2019

Taking this out of https://github.com/apiaryio/dredd-hooks-template/pull/65/files#r290878471 where @kylef proposes:

Maybe in this case if a process doesn't gracefully exit from SIGTERM that should be a test failure too (instead of having to SIGKILL it).

This is a proposal to add a feature, which ensures the hooks handlers can react to SIGTERM correctly (SIGINT could be tested too).

Downsides of introducing this is that it would be slightly harder to write a hooks handler (the author already needs to know TCP, now they'd need to know what signals are and how they work) and that SIGTERM (or any alternative to it) doesn't exist on Windows, which would make it complicated for those either aiming for Windows support (#21) or developing the hooks handler on Windows (no way to test locally that it works).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant