Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the --port option #81

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

honzajavorek
Copy link
Contributor

@honzajavorek honzajavorek commented Jun 27, 2019

This is a kick off to address the long-pending #11 and #17. Big thanks to @ddelnano for contributing the initial work and opening the discussion back in the days. I'm sorry this is taking so long to tackle, but as you can see in apiaryio/dredd#917, it got stuck on various circular chicken-egg dependency issues.

Closes #11, closes #17

BREAKING CHANGE: After this PR gets merged, it is going to be required that the hooks handler process is able to accept a --port option in addition to the list of hook files.

BREAKING CHANGE: It is now required that the hooks handler process is able to accept a --port option in addition to the list of hook files.
@honzajavorek honzajavorek added this to In progress in SJS via automation Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
SJS
  
In progress
Development

Successfully merging this pull request may close these issues.

Tests do not validate hooks can listen on different ports
1 participant