Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #6446] Add tests for Spark saveToFile function #6467

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lsm1
Copy link
Contributor

@lsm1 lsm1 commented Jun 14, 2024

🔍 Description

Issue References 🔗

This pull request fixes #6446

Describe Your Solution 🔧

Add tests for Spark saveToFile function

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklist 📝

Be nice. Be informative.

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.73%. Comparing base (1fb1f85) to head (433f78c).
Report is 29 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6467      +/-   ##
============================================
- Coverage     58.34%   54.73%   -3.61%     
  Complexity       24       24              
============================================
  Files           656      680      +24     
  Lines         40264    43012    +2748     
  Branches       5498     5964     +466     
============================================
+ Hits          23493    23544      +51     
- Misses        14272    16957    +2685     
- Partials       2499     2511      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lsm1 lsm1 force-pushed the branch-kyuubi-6446 branch 3 times, most recently from c5aa233 to 6311552 Compare June 24, 2024 03:07
@lsm1 lsm1 marked this pull request as ready for review June 24, 2024 12:01
@cxzl25 cxzl25 added this to the v1.10.0 milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK][EASY] Add tests for Spark saveToFile function
3 participants