[Fix-3805] Remove redundant values in table t_flink_app insert statement
#3807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfboys
reviewed
Jun 25, 2024
| @@ -30,7 +30,12 @@ insert into `t_team` values (100000, 'default', null, now(), now()); | |||
| -- ---------------------------- | |||
| -- Records of t_flink_app | |||
| -- ---------------------------- | |||
| insert into `t_flink_app` values (100000, 100000, 2, 4, null, null, 'Flink SQL Demo', null, null, null, null, null, null , null, 100000, null, 1, null, null, null, null, null, null, null, null, 0, 0, null, null, null, null, null, null, 'Flink SQL Demo', 0, null, null, null, null, null, null, null, 0, 0, now(), now(), null, 1, 1, null, null, null, null, null, null, 0, null, null, null, 'streampark,test', 0, null); | |||
There was a problem hiding this comment.
I suggest using insert table $table($column1,$column2,$column3) values(...) instead of insert into $table values(...) it is a better solution
zzzk1
force-pushed
the
Fix-3805-data-script
branch
2 times, most recently
from
64b5f06
to
733dd38
Compare
wolfboys
reviewed
Jun 26, 2024
| `id`, `team_id`, `job_type`, `execution_mode`, `job_name`, `user_id`, `app_type`, `state`, `restart_size`, | ||
| `description`,`resolve_order`,`option_state`,`tracking`,`create_time`, `modify_time`,`release`, `build`, | ||
| `k8s_hadoop_integration`,`tags`, `hadoop_user` | ||
| ) VALUES (100000, 100000, 2, 4, 'Flink SQL Demo', 100000, 1, 0, 0, 'Flink SQL Demo', 0, 0, 0, now(), now(), 1, 1, 0, 'streampark,test', 0); |
zzzk1
force-pushed
the
Fix-3805-data-script
branch
from
733dd38
to
ae1fbdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request
The dml of table
t_flink_appin existing H2, MySQL, PGSQL does not match the dll struct.Issue Number: close #3805
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts