Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Add CPP unit test for UDF #6195

Open
NEUpanning opened this issue Jun 24, 2024 · 3 comments
Open

[VL] Add CPP unit test for UDF #6195

NEUpanning opened this issue Jun 24, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@NEUpanning
Copy link
Contributor

Description

The UDF examples only have TestMyUDF.cc for testing whether UDF is registered and VeloxUdfSuite.scala for integration test. In our practice, we need compile gluten java code for testing after changing the UDF cpp code, which takes a lot of time. Maybe we should add unit test like Velox functions test so we can save the time for doing scala test.

@NEUpanning NEUpanning added the enhancement New feature or request label Jun 24, 2024
@Yohahaha Yohahaha changed the title Add CPP unit test for UDF [VL] Add CPP unit test for UDF Jun 25, 2024
@NEUpanning
Copy link
Contributor Author

@marin-ma How do you think? Thanks!

@marin-ma
Copy link
Contributor

@NEUpanning +1 Thanks for the proposal. We have one simple executable here to test the UDF registration https://github.com/apache/incubator-gluten/blob/main/cpp/velox/udf/examples/TestMyUDF.cc Not sure if it would be helpful to create the UDF CPP test framework.

Would you like to help on implementing this?

@NEUpanning
Copy link
Contributor Author

@marin-ma Thanks for your reply. I would like to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants