Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] SendMessageRequestHeader, SendMessageBatchRequestHeader and SendMessageBatchV2RequestHeader have almost same body #3892

Open
2 tasks done
pandaapo opened this issue May 9, 2023 · 1 comment · May be fixed by #3893
Open
2 tasks done

[Enhancement] SendMessageRequestHeader, SendMessageBatchRequestHeader and SendMessageBatchV2RequestHeader have almost same body #3892

pandaapo opened this issue May 9, 2023 · 1 comment · May be fixed by #3893
Labels
enhancement New feature or request Stale

Comments

@pandaapo
Copy link
Member

pandaapo commented May 9, 2023 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

  • SendMessageRequestHeader, SendMessageBatchRequestHeader and SendMessageBatchV2RequestHeader have almost same body.
  • Assert.assertThat() is deprecated in junit.
  • There is a more convenient method of initializing Map.

Describe the solution you'd like

  • Abstract SendMessageRequestHeader, SendMessageBatchRequestHeader and SendMessageBatchV2RequestHeader these three classes.
  • Use other api of junit.
  • Use ImmutableMap.of() to create and init Map.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@pandaapo pandaapo added the enhancement New feature or request label May 9, 2023
@pandaapo pandaapo linked a pull request May 10, 2023 that will close this issue
Open
@github-actions GitHub Actions
Copy link
Contributor

It has been 90 days since the last activity on this issue. Apache EventMesh values the voices of the community. Please don't hesitate to share your latest insights on this matter at any time, as the community is more than willing to engage in discussions regarding the development and optimization directions of this feature.

If you feel that your issue has been resolved, please feel free to close it. Should you have any additional information to share, you are welcome to reopen this issue.

@github-actions github-actions bot added the Stale label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Stale
Projects
None yet
Milestone
No milestone
1 participant
@pandaapo