-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to display byte count for Top-languages #3707
Comments
Hey, @abap34! Thanks for your interest in our project and submitting feature request. You're right, we use top issues dashboard to prioritize and track community demand, if this feature will be supported by the community feel free to open a pull request for me to review. |
Thank you for your response @qwerty541! |
Just want to additionally note that we can avoid neccesity of making changes in layout by shorter formatting of bytes numbers: 670,404 bytes => 670k bytes. Also we can convert bytes in KB, MB and GB when it will be enough for one unit: 670,404 bytes => 670KB. |
That idea sounds very good! This issue seems to be featured on the dashboard, so I will implement it and send a pull request. |
I want to warn you in advance that review and merging of your pull request can be postponed for several months. We have rule in our team that merging features require approval of at least 2 members. Currently I'm alone active, other members busy, so don't hurry with opening pull request. |
Oh, I see. Thank you for letting me know. |
Thanks for your efforts implementing this feature and for your kind words. I just left a review #3708 (review). |
Is your feature request related to a problem? Please describe.
Currently, the Top Language Card only displays the percentage of each language used. However, adding an option to display byte counts could incentivize more coding activity, thereby increasing the amount of code generated by individuals.
Describe the solution you'd like
I have already implemented this on my self-hosted github-readme-stats.
( So, if there is demand for this feature from the community, I can clean up the implementation and submit a pull request :)
This can be achieved by making minor modifications to the
api/top-lang.js
andsrc/cards/top-languages-card.js
.Describe alternatives you've considered
No response
Additional context
It might require CSS adjustments for many layouts. For instance, the default layout appears as follows:
The text was updated successfully, but these errors were encountered: