Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for proper spaces around punctuation #1342

Open
RedX2501 opened this issue Feb 2, 2023 · 3 comments
Open

Check for proper spaces around punctuation #1342

RedX2501 opened this issue Feb 2, 2023 · 3 comments
Labels
cat: maintenance Issues and PRs related to the maintenance of a module. priority: low Issues and PRs that should be resolved, but can be postponed. status: needs-help Issues and PRs that require volunteer assistance to proceed. type: refactor Issues and PRs related to code cleanup. version: minor Issues and PRs with new features belonging to the next minor release.

Comments

@RedX2501
Copy link

RedX2501 commented Feb 2, 2023

I see that there's a rule for two spaces after a period but there does not seem to be a rule for the spacing around commas, parenthesis, braces and so on.

Is there no consensus or recommendation around this from your sources?

I have seem many (now I'm not sure if they really are problems) with other writers having spaces around commas, after an opening parenthesis and so on.

@arostkowycz15
Copy link

I will attempt this issue.

@samanth-jain
Copy link

Can i work on this issue?

@Nytelife26
Copy link
Member

Nytelife26 commented Aug 31, 2023

Is there no consensus or recommendation around this from your sources?

This is a purely typographical issue. However, since we already have some checks and sources for typography, this is what I could find on the matter: https://practicaltypography.com/are-two-spaces-better-than-one.html

In the one rather isolated and statistically questionable study we have in recent years, 1-1 and 2-1 spacing perform the best.

Logically, whatever we decide upon should be one of those, since they're the most commonly used forms of spacing. However, I am inclined to throw this out altogether - there is no proven best option, and I consider typography quite adjacent to prose.

@Nytelife26 Nytelife26 added type: refactor Issues and PRs related to code cleanup. priority: low Issues and PRs that should be resolved, but can be postponed. version: minor Issues and PRs with new features belonging to the next minor release. status: needs-help Issues and PRs that require volunteer assistance to proceed. cat: maintenance Issues and PRs related to the maintenance of a module. labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: maintenance Issues and PRs related to the maintenance of a module. priority: low Issues and PRs that should be resolved, but can be postponed. status: needs-help Issues and PRs that require volunteer assistance to proceed. type: refactor Issues and PRs related to code cleanup. version: minor Issues and PRs with new features belonging to the next minor release.
Projects
None yet
Development

No branches or pull requests

4 participants