Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deploys based on PRs to make it easier to test them #2432

Open
2 tasks done
george-gca opened this issue May 21, 2024 · 3 comments
Open
2 tasks done
Assignees

Comments

@george-gca
Copy link
Collaborator

Have you checked that your feature request isn't already filed?

  • I read through FAQ and searched through the past issues, none of which addressed my feature request.
  • Yes, I have checked that this feature request isn't already filed.

Description & Motivation

To have a deployed version of the site ready to be tested based on a PR would make it much simpler for us (maintainers) to validate them.

Pitch

No response

Alternatives

I was able to make it work for Netlify only.

Additional context

Suggested in #1981, made it work for a forked repo and shown in #2415.

Steps needed:

  1. Create an account in Netlify
  2. Add a Deploy with Git from this template (note: you should give access to Netlify to your repositories, but this can be limited by repo)
  3. In the new deployed site, go to Site configuration -> Build & deploy -> Continuous deployment -> Build settings. Set the Build command as sed -i "s/^\(baseurl: \).*$/baseurl:/" _config.yml && bundle exec jekyll build and the Publish directory as _site. This can be seen in the screenshot below:

image

  1. Enable Deploy Previews
@alshedivat
Copy link
Owner

@george-gca, that sounds like a great idea. let me set this up. also, appreciate all the features you've been shipping! 🚀

@george-gca
Copy link
Collaborator Author

The best way to test this is to create a PR with a really obvious change and see if after a while the Netlify bot adds the link to the built page in the PR.

@george-gca
Copy link
Collaborator Author

How is it going? Need any help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants