Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify report_matplotlib_figure to Omit Iteration Value When iteration=None #1267

Open
scott-kim94 opened this issue May 17, 2024 · 3 comments

Comments

@scott-kim94
Copy link

Proposal Summary

The report_matplotlib_figure method currently sets the iteration value to 0 when the iteration parameter is None. This results in an unnecessary display of "iteration 0". I propose that the method be modified so that if iteration is None, the iteration value should not be displayed.
image

Motivation

In many cases, users may not want to specify an iteration value when reporting a matplotlib figure. Setting the default iteration value to 0 can be misleading and clutter the report with unnecessary information. By omitting the iteration value when iteration=None, the reported plots will be cleaner and more accurate, reflecting the user's intention not to specify an iteration.

Related Discussion

N/A

@ainoam
Copy link
Collaborator

ainoam commented May 20, 2024

Thanks for suggesting @scott-kim94.

Without going into ClearML internals, do you mean that when a single plot is reported, with no iteration value, no iteration value should appear in the title?

@scott-kim94
Copy link
Author

scott-kim94 commented May 31, 2024

@ainoam

report_matplotlib_figure(
            title=f"Data Bias/{data_type}",
            series="Image Size Distribution",
            iteration=None,
            figure=plt,
            report_interactive=False,
        )

I saw your answer too late. I'm sorry.
Yes, that’s right.
In the case of a plot that has no correlation with iteration, iteration information is not required,
so the default value of 0 is output even though it is entered as None.

@ainoam
Copy link
Collaborator

ainoam commented Jun 2, 2024

@scott-kim94 Indeed this seems like a bug that has crept in - iteration should not show in UI in this case. We'll try to address in a near version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants