-
-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
MetalLB: update to v0.13.9 #898
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project. Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken. 馃挕 Shall we fix this?This will only take a few moments. First, clone your fork and checkout this branch using the git CLI. Next, set up your real name and email address:
Finally, run one of these commands to add the "Signed-off-by" line to your commits. If you only have one commit so far then run: Check that the message has been added properly by running "git log". |
- now uses a single manifest - supports aarch64 (ARM), so remove the Intel-only restriction Signed-off-by: Carlos Laviola <[email protected]>
Hey thanks for working on this PR for Arm support for MetalLB. I always feel uncomfortable merging things when I see the words "it should work" and then under testing, I don't see any evidence that the thing being fixed has been tested. Under Feel free to look at merged PRs for where the other contributors have done this. Cheers, Alex |
All done! |
Actually there's a small change in configuration required for this to be done seamlessly. As per the docs, something like this has to be created at the same time as the address pool: apiVersion: metallb.io/v1beta1
kind: L2Advertisement
metadata:
聽 name: example
聽 namespace: metallb-system do you have any suggestions for the name of this |
Unfortunately I'm having trouble changing from the ConfigMap to CRDs. Is it alright to just output text telling the user what to do to configure the app further, like in other apps such as https://github.com/claviola/arkade/blob/master/cmd/apps/kubernetes_dashboard_app.go#L83? |
Can you elaborate please? I'll try to help |
Description
Motivation and Context
Updating the MetalLB chart to v0.13.9 should fix #896, ie. allow it to be installed on ARM.
design/approved
by a maintainer (required)I have indeed raised an issue to propose this change, but I do not yet understand how the labelling works. However, since @alexellis asked me if I'd fix it myself I've gone ahead and done it. I'm sure we can work out the details.
How Has This Been Tested?
Followed all the steps in CONTRIBUTING - including building and attempting to reinstall:
Types of changes
Documentation
./arkade get -o markdown
./arkade install --help
Checklist:
git commit -s