Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Adding Helm CT/CR #688

Open
1 of 2 tasks
oliverbaehler opened this issue May 10, 2022 · 5 comments
Open
1 of 2 tasks

Feature Request: Adding Helm CT/CR #688

oliverbaehler opened this issue May 10, 2022 · 5 comments

Comments

@oliverbaehler
Copy link

Expected Behaviour

arkade get ct installs the Chart-Testing binary
arkade get cr installs the Chart-Releaser binary

Current Behaviour

Are you a GitHub Sponsor yet (Yes/No?)

  • Yes
  • No

Possible Solution

Add cr and ct to the tools.go file.

Context

If requesting a CLI for "arkade get"

How many downloads does this tool have? Check at:

https://somsubhra.github.io/github-release-stats/

ct- 366,510
cr- 82,443

Your Environment

  • What Kubernetes distribution are you using?
Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.4", GitCommit:"e6c093d87ea4cbb530a7b2ae91e54c0842d8308a", GitTreeState:"clean", BuildDate:"2022-02-16T12:38:05Z", GoVersion:"go1.17.7", Compiler:"gc", Platform:"darwin/arm64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.9", GitCommit:"b631974d68ac5045e076c86a5c66fba6f128dc72", GitTreeState:"clean", BuildDate:"2022-01-19T17:45:53Z", GoVersion:"go1.16.12", Compiler:"gc", Platform:"linux/amd64"}
WARNING: version difference between client (1.23) and server (1.21) exceeds the supported minor version skew of +/-1
  • Operating System and version (e.g. Linux, Windows, MacOS):
21.3.0 Darwin Kernel Version 21.3.0: Wed Jan  5 21:37:58 PST 2022; root:xnu-8019.80.24~20/RELEASE_ARM64_T6000 arm64
  • What arkade version is this?
0.8.23
@Shikachuu
Copy link
Contributor

Hey @oliverbaehler,

Thanks for the suggestions! CR (Chart-Releaser) seems fine, feel free to create a PR for it, if you intrested!

I am afraid that CT (Chart-Testing) has some dependencies that you can't install from arkade like Yamale and Yamllint (both of them written in python and does not have a static binary), without them 2 of the 5 available sub commands will not work.

Note that linting requires config file for yamllint and yamale. If not specified, these files are search in the current directory, $HOME/.ct, and /etc/ct, in that order. Samples are provided in the etc folder.

I think it'll cause some problems for most of the users and we should not add it yet.
Am I correct here @welteki or @alexellis?

@alexellis
Copy link
Owner

I think you might be right @Shikachuu

@alexellis
Copy link
Owner

@oliverbaehler how do you want to proceed?

The Go binaries can be installed, but you or your users will need to install those Python packages separately by the sounds of it.

@oliverbaehler
Copy link
Author

@alexellis if it's okay i would proceed with creating a pr for both. I am using arkade as part of a docker image which is used for ci purposes and it would be handy to install ct via ark.

@Shikachuu
Copy link
Contributor

@oliverbaehler, sure!
Please create a single PR for each tool.

@Shikachuu Shikachuu mentioned this issue Aug 29, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants