Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended IME support for @internationalized/number #6623

Open
Rocss opened this issue Jun 26, 2024 · 2 comments
Open

Extended IME support for @internationalized/number #6623

Rocss opened this issue Jun 26, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Rocss
Copy link

Rocss commented Jun 26, 2024

Provide a general summary of the feature here

I'm playing around with the @internationalized/number and I want to insert numbers using Hindi keyboard. I observed that @internationalized/number allows 'latn', 'arab', 'hanidec' numeric systems, and it works well for arabic keyboard, but it does not work for Hindi keyboard.

🤔 Expected Behavior?

It would be nice to be able to enter numbers using the Hindi - standard and Bengali - standard the same way it works for 'latn', 'arab' and 'hanidec' right now.

😯 Current Behavior

Nothing happens when I type in the number field (which uses @internationalized/number ) using Hindi keyboard.

💁 Possible Solution

Adding deva and beng here: https://github.com/adobe/react-spectrum/blob/main/packages/%40internationalized/number/src/NumberParser.ts#L26 would support Hindi and Bengali IME

Screenshot 2024-05-10 at 12 05 29

🔦 Context

This request comes from our g18n team.
Adobe Express supports a large range of languages. We want to provide users the complete experience by allowing to use the corresponding IME for the language selected.
That would be Japanese, Korean, Simplified Chinese, Traditional Chinese, Hindi, Thai, Bengali, Tamil as the main ones with complex scripts.

💻 Examples

No response

🧢 Your Company/Team

Adobe Express

🕷 Tracking Issue

No response

@Rocss
Copy link
Author

Rocss commented Jun 26, 2024

A side note here would be that in Spectrum Web Components, (which uses @internationalized/number) we resolved the double-byte characters support, therefore Japanese works there. I am not sure if this can be resolved in the @internationalized/number, but anyway it is not a priority.

@snowystinger
Copy link
Member

Hi, can you please reach out internally, we have a conversation going about adding numbering systems already.

@LFDanLu LFDanLu added the enhancement New feature or request label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants