Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose FocusableProvider from monopackage #6578

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

snowystinger
Copy link
Member

Closes #6574

Is this something we want to expose?
Docs?

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger snowystinger marked this pull request as ready for review June 21, 2024 06:22
@LFDanLu
Copy link
Member

LFDanLu commented Jun 21, 2024

I still feel a bit iffy about exposing FocusableProvider since it feels like using this provider may cause various props to unintentionally be added to components that have useFocusable called for them under the hood via their hooks. Users would need to make sure only to just wrap the TooltipTrigger children with it, which isn't so bad since that seem to be the only use case for it right now but that could potentially change in the future. Maybe since the current usage is so limited to specifically tooltips we could perhaps instead tweak the hooks or add a solely tooltip specific way of propagating the pointerEnter/other props from useTooltipTrigger to tooltip button?

@snowystinger
Copy link
Member Author

Linking another comment from a confused user #1175 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useTooltipTrigger's trigger props do not work when used with useButton
2 participants