Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree crashes when trying to set expandedKeys = "all" #6568

Open
larrifax opened this issue Jun 19, 2024 · 1 comment
Open

Tree crashes when trying to set expandedKeys = "all" #6568

larrifax opened this issue Jun 19, 2024 · 1 comment

Comments

@larrifax
Copy link

Provide a general summary of the issue here

I'm trying to use the new Tree component from react-aria-components, but it crashes when attempting to set expandedKeys prop to "all" (which should be a valid value according to the types).

See reproduction below

🤔 Expected Behavior?

Tree should successfully expand all possible keys

😯 Current Behavior

Tree crashes with error:

expandedKeys.has is not a function
visitNode
https://lz5k72.csb.app/node_modules/react-aria-components/dist/Tree.main.js:418:71
visitNode
https://lz5k72.csb.app/node_modules/react-aria-components/dist/Tree.main.js:421:60
$c6576bb58bfa084b$var$flattenTree
https://lz5k72.csb.app/node_modules/react-aria-components/dist/Tree.main.js:423:33
new $c6576bb58bfa084b$var$TreeCollection
https://lz5k72.csb.app/node_modules/react-aria-components/dist/Tree.main.js:103:64

💁 Possible Solution

No response

🔦 Context

No response

🖥️ Steps to Reproduce

https://codesandbox.io/p/sandbox/priceless-rgb-lz5k72

  1. Click the Expand explicit button. Expansion is performed as expected
  2. Click the Expand all button. Tree crashes and error message is displayed

Version

1.2.1

What browsers are you seeing the problem on?

Chrome

If other, please specify.

No response

What operating system are you using?

Windows

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

@larrifax
Copy link
Author

Looks like I've might have jumped the gun a bit here wrt. this being a bug vs a feature request (?).

The types doesn't really allow "all" in its type, but Typescript doesn't complain either when you supply it. 🤷
Also, the convertExpanded()-function that's used on the incoming expandedKeys-prop seems to support "all" as a value, so it tricked me into believing that it was intended to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant