Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Rollover overspending indicators pushed off screen in mobile view #2879

Open
1 task done
matt-fidd opened this issue Jun 13, 2024 · 7 comments · May be fixed by #2943
Open
1 task done

[Bug]: Rollover overspending indicators pushed off screen in mobile view #2879

matt-fidd opened this issue Jun 13, 2024 · 7 comments · May be fixed by #2943
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed user interface Related to the user interface

Comments

@matt-fidd
Copy link
Contributor

matt-fidd commented Jun 13, 2024

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

As above, image below.

image

@matt-fidd matt-fidd added the bug Something isn't working label Jun 13, 2024
@joel-jeremy joel-jeremy added good first issue Good for newcomers help wanted Extra attention is needed user interface Related to the user interface labels Jun 15, 2024
@dymanoid
Copy link
Contributor

Will be happy to work on this. Please also see my comment in #2774.

@youngcw
Copy link
Contributor

youngcw commented Jun 24, 2024

I think that the a better solution would be to somehow integrate the arrow into the pill around the value. Maybe the pill should run up against the side of the screen and then the arrow can be inside the pill along with the amount

@dymanoid
Copy link
Contributor

Here are three possible solutions. Which one do you prefer?
I don't like the 3rd one where the dark value containers extend to the right to cover the carryover arrow.
I personally prefer the 1st one where the arrows are outside of the value containers, so basically the current design. But the 2nd one is also okay.
So what are your thoughts?
Variant 1:
a1

Variant 2:
a2

Variant 3:
a3

@youngcw
Copy link
Contributor

youngcw commented Jun 25, 2024

@dymanoid
option 1 would match desktop the most and is the most similar to existing. I wouldn't be against option 2 though if others liked that more.

With option 3 could the pill be squared against the side? So no rounded right side.
that might make it feel less inconsistent.

@dymanoid
Copy link
Contributor

Something like this?

image

@youngcw
Copy link
Contributor

youngcw commented Jun 25, 2024

@dymanoid Yeah that was what I was thinking. It still seems a bit weird, but its an option. My hope is that we don't have to lose more space just to make it look good if possible. That extended pill could maybe do that and maybe different enough from the regular pill to not look wrong or missaligned

@dymanoid
Copy link
Contributor

After discussing on Discord, this what we decided to implement:
image

@dymanoid dymanoid linked a pull request Jun 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed user interface Related to the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants