Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace: display scrollbar only if the items exceed on the page #6818

Open
withshubh opened this issue Jun 22, 2023 · 48 comments · May be fixed by #10163 or #10180
Open

Marketplace: display scrollbar only if the items exceed on the page #6818

withshubh opened this issue Jun 22, 2023 · 48 comments · May be fixed by #10163 or #10180
Assignees
Labels
bug Something isn't working good first issue Good for newcomers marketplace up-for-grabs

Comments

@withshubh
Copy link
Contributor

Current Behavior:

The Installed & Marketplace page in ToolJet displays a scrollbar at all times, even when there are no items present on the page.

Steps to Reproduce:

  1. Set up ToolJet locally.
  2. Enable the Marketplace feature following the instructions provided in the ToolJet documentation (https://docs.tooljet.com/docs/contributing-guide/marketplace/marketplace-setup).
  3. Navigate to the Marketplace section.
  4. Observe that a scrollbar is present on the page, regardless of the number of items displayed.

Expected Solution:

To resolve this issue, the scrollbar should only appear when the number of items on the page exceeds the available space. When there are no items or when the items fit within the page, the scrollbar should not be displayed, providing a more visually streamlined and intuitive user interface.

Screenshots or Screencast

Screen.Recording.2023-06-22.at.4.39.19.PM.mov
@withshubh withshubh added bug Something isn't working good first issue Good for newcomers up-for-grabs labels Jun 22, 2023
@ShivangRawat30
Copy link
Contributor

I would like to work on this issue.

@withshubh
Copy link
Contributor Author

Hey @ShivangRawat30 - Thanks for showing interest in contributing to ToolJet. Assigned it to you.

@tejakummarikuntla
Copy link
Contributor

Hey @ShivangRawat30 , We noticed that you were working on an issue, and we wish you the best in making progress on it. However, given this issue is labeled as a good first issue, we were wondering if it's possible to assign it to someone new to the project. If you haven't started working on it yet, kindly let us know so we can proceed accordingly. We appreciate your understanding and cooperation.

@tejakummarikuntla
Copy link
Contributor

The contributor was unassigned due to inactivity.

@webAbhi
Copy link
Contributor

webAbhi commented Aug 7, 2023

Hey @tejakummarikuntla i would like to help here. can u please assign this to me ?

@tejakummarikuntla
Copy link
Contributor

Hey @webAbhi , I appreciate your interest in contributing; thank you.
Since this issue holds the label good first issue let's wait to welcome other first-time contributors like yourself.

@tejakummarikuntla tejakummarikuntla added good first issue Good for newcomers up-for-grabs and removed good first issue Good for newcomers up-for-grabs labels Aug 10, 2023
@VinayakSingh2001
Copy link

Hey @tejakummarikuntla I would like to work on this, can you please assign this to me !!

@Shweta-Tapele
Copy link

Hey @tejakummarikuntla I would like to work on this, if anyone hasn't already started working on it.

@tejakummarikuntla
Copy link
Contributor

Hey @VinayakSingh2001 , since there's an issue assigned to you. Assigned this issue to @Shweta-Tapele

@tejakummarikuntla
Copy link
Contributor

Hey @Shweta-Tapele Given the duration of the assignment with no recent updates, we need to unassign the task. Your understanding and cooperation in this matter are greatly appreciated.

@JunedKhan101
Copy link
Contributor

@tejakummarikuntla Can you assign this to me? I'd like to work on it.

@tejakummarikuntla
Copy link
Contributor

Hey @JunedKhan101 , We greatly appreciate your interest. However, we would like to wait and see if there are any first-time contributors who are also interested in this opportunity. We hope you understand our decision and thank you for your understanding.

@tejakummarikuntla tejakummarikuntla added good first issue Good for newcomers up-for-grabs and removed good first issue Good for newcomers up-for-grabs labels Sep 13, 2023
@tejakummarikuntla tejakummarikuntla added good first issue Good for newcomers and removed good first issue Good for newcomers up-for-grabs labels Sep 26, 2023
@2001asjad
Copy link
Contributor

Hi @Ded-Codes , are you still working on this issue?

@Ded-Codes
Copy link

Ded-Codes commented Apr 12, 2024

Hi @Ded-Codes , are you still working on this issue?

I'm trying to contribute for the first time and encountered some issues while setting it up on my local machine (macOS).
Due to these setup issues, I'm currently unable to work on resolving the scrollbar issue.

@2001asjad
Copy link
Contributor

Hey @Ded-Codes , you con join ToolJet's Slack, and ask your queries in the Contributors channel.

@2001asjad
Copy link
Contributor

@Ded-Codes, let me know if you're going forward with the issue.

@karan-rathod-316
Copy link
Collaborator

Unassigned due to lack of progress.

@gdhyani
Copy link

gdhyani commented Apr 23, 2024

can i work on this? @karan-rathod-316

@2001asjad
Copy link
Contributor

Hey, @gdhyani, I am assigning this issue to you. Happy Coding :)

@2001asjad
Copy link
Contributor

@gdhyani , are there any updates?

@2001asjad
Copy link
Contributor

Unassigned due to lack of progress.

@SohamPatel0810
Copy link

Hi,
Can you please assign this task to me ?

@2001asjad
Copy link
Contributor

Hi @SohamPatel0810, I am assigning this issue to you. Thanks for your interest in contributing to ToolJet!

@PriteshKiri
Copy link
Collaborator

Hey @SohamPatel0810 ,
Any updates on this issue?

@ShyanRoyChoudhury
Copy link

Please assist it to me. I would love to fix it.

@PriteshKiri
Copy link
Collaborator

@ShyanRoyChoudhury assigned it to you. Happy coding :)

@PriteshKiri
Copy link
Collaborator

PriteshKiri commented Jun 25, 2024

Thanks for the quick fix @ShyanRoyChoudhury. Moving it to review.

@ShyanRoyChoudhury
Copy link

@PriteshKiri Someone else who is not assigned did it. Not me.

@PriteshKiri
Copy link
Collaborator

Sorry @ShyanRoyChoudhury I missed that. Moving it back to development. Let me know when you are done with the issue.

@Sanil-Surve
Copy link

Hey @PriteshKiri , Can you assign me this issue bcoz I can solve this I have came across such issues in earliar development Experience.

@PriteshKiri
Copy link
Collaborator

Thank you for your contribution @ShyanRoyChoudhury. I am moving the PR to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment