Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[watermill-http] It doesn't support multi subscribes for the same single topic #280

Open
tymonx opened this issue Apr 12, 2022 · 1 comment · May be fixed by ThreeDotsLabs/watermill-http#10

Comments

@tymonx
Copy link

tymonx commented Apr 12, 2022

The go-chi HTTP router used in the Watermill HTTP overrides added handlers for the same route. Because of that when calling httpSubscriber.Subscribe(ctx, url) with the same url N times it will invoke added HTTP handlers only once. Simple use case for the CQRS component with queue per package name not per packageName.CommandName/EventName. Received message from HTTP client will be delivered randomly only to one of registered command or event handler with the same topic name not to all added handlers. In that case the Watermill HTTP doesn't work as pub/sub.

@tymonx
Copy link
Author

tymonx commented Apr 12, 2022

I have prepared Pull Request with necessary fixes for this issue ThreeDotsLabs/watermill-http#10 I don't know why CI fails for go build ./.... Locally it works perfectly fine without any problems.

@tymonx tymonx changed the title [watermill-http] It doesn't support multi subscribe for the same single topic [watermill-http] It doesn't support multi subscribes for the same single topic Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant