Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct typing when directly returing a DeferredPromise in a loader #1820

Closed
wants to merge 1 commit into from
Closed

fix: correct typing when directly returing a DeferredPromise in a loader #1820

wants to merge 1 commit into from

Conversation

schiller-manuel
Copy link
Contributor

fixes #1818

however, we first need to make sure that returning a deferred promise directly works correct at runtime!

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 23, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 28a0166. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@schiller-manuel
Copy link
Contributor Author

before this change:

> tsc --extendedDiagnostics

Files:                         646
Lines of Library:            38411
Lines of Definitions:        88232
Lines of TypeScript:         21604
Lines of JavaScript:             0
Lines of JSON:                   0
Lines of Other:                  0
Identifiers:                141626
Symbols:                    324171
Types:                      114839
Instantiations:             788962
Memory used:               362817K
Assignability cache size:    49166
Identity cache size:          8638
Subtype cache size:           2426
Strict subtype cache size:     413
I/O Read time:               0.02s
Parse time:                  0.26s
ResolveModule time:          0.04s
ResolveTypeReference time:   0.00s
ResolveLibrary time:         0.01s
Program time:                0.37s
Bind time:                   0.13s
Check time:                  2.92s
printTime time:              0.00s
Emit time:                   0.00s
Total time:                  3.42s

after this change:

> tsc --extendedDiagnostics

Files:                         646
Lines of Library:            38411
Lines of Definitions:        88233
Lines of TypeScript:         21604
Lines of JavaScript:             0
Lines of JSON:                   0
Lines of Other:                  0
Identifiers:                141636
Symbols:                    324388
Types:                      115054
Instantiations:             799491
Memory used:               364470K
Assignability cache size:    49574
Identity cache size:          8436
Subtype cache size:           2426
Strict subtype cache size:     413
I/O Read time:               0.03s
Parse time:                  0.26s
ResolveModule time:          0.05s
ResolveTypeReference time:   0.00s
ResolveLibrary time:         0.01s
Program time:                0.39s
Bind time:                   0.13s
Check time:                  2.84s
printTime time:              0.00s
Emit time:                   0.00s
Total time:                  3.36s

Instantiations increased from 788962 to 799491

@schiller-manuel schiller-manuel force-pushed the fix-loader-return-DeferredPromise branch from 4637c9a to 28a0166 Compare June 23, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected behaviour when returning defer() value without wrapping in an object
1 participant
@schiller-manuel