Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect ProductVersion property for Uninstall Registry Key #355

Open
rakleed opened this issue Nov 8, 2023 · 1 comment
Open

Incorrect ProductVersion property for Uninstall Registry Key #355

rakleed opened this issue Nov 8, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@rakleed
Copy link

rakleed commented Nov 8, 2023

Describe the bug
The ProductVersion property for Uninstall Registry Key is version 4.

To Reproduce
Steps to reproduce the behavior:

  1. Install latest version of TcNo Account Switcher
  2. Open Windows 11 Settings
  3. Go to Apps, then Installed Apps
  4. Find TcNo Account Switcher in the list

Expected behavior
The ProductVersion property for Uninstall Registry Key indicates the current version 5.0 - 2023-07-05_00.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 11 23H2
  • TcNo Account Switcher: v5.0 - 2023-07-05_00

Additional context

@rakleed rakleed added the bug Something isn't working label Nov 8, 2023
@Eddga
Copy link

Eddga commented Nov 12, 2023

+1
But: @rakleed in any case you commited the wrong version number in the installer yaml here: microsoft/winget-pkgs#125068
I'm using Winget-AutoUpdate and it updated today as soon as it found the app in winget and thought that 2023-07-05_00 was bigger than 4 (which is true, but... yeah) even though I already was at that version. And now my complete TcNo config is gone for some reason. Not cool.

As long as this issue here isn't resolved the version in winget has to be 4 like it is when installed - even when this means that it breaks winget update functionality. Otherwise this always shows as an update being available for that particular app.
I already created another PR to have that fixed.

@TCNOco As soon as this is fixed and for future versions you might consider using winget for updating the app and also could have your newest version automatically uploaded to the winget-pkgs repo. This could also help get some users updated from older versions like you mentioned here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants