Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reloading Causes Error on 1.20.6 #6735

Open
1 task done
ExtraSmartMiner opened this issue May 28, 2024 · 3 comments
Open
1 task done

Reloading Causes Error on 1.20.6 #6735

ExtraSmartMiner opened this issue May 28, 2024 · 3 comments
Assignees
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.

Comments

@ExtraSmartMiner
Copy link

Skript/Server Version

[11:20:51 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[11:20:51 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[11:20:51 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[11:20:51 INFO]: [Skript] Server Version: 1.20.6-115-9d6f2cc (MC: 1.20.6)
[11:20:51 INFO]: [Skript] Skript Version: 2.8.5 (skriptlang-github)
[11:20:51 INFO]: [Skript] Installed Skript Addons:
[11:20:51 INFO]: [Skript]  - Skellett v2.0.10 (https://forums.skunity.com/resources/skellett.24/)
[11:20:51 INFO]: [Skript]  - skUtilities v0.9.2 (https://tim740.github.io/)
[11:20:51 INFO]: [Skript]  - SkQuery v4.1.10
[11:20:51 INFO]: [Skript]  - SkBee v3.5.2 (https://github.com/ShaneBeee/SkBee)
[11:20:51 INFO]: [Skript]  - SkJade v1.4.3 (https://www.github.com/Ankoki-Dev/SkJade)
[11:20:51 INFO]: [Skript] Installed dependencies:
[11:20:51 INFO]: [Skript]  - WorldGuard v7.0.10+d9424b1

Bug Description

reloading any skript file gives me the error:

[11:20:01 ERROR]: Caught previously unhandled exception :
[11:20:01 ERROR]: Paper Async Command Builder Thread Pool - 0
java.util.ConcurrentModificationException: null
at java.base/java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:1023) ~[?:?]
at java.base/java.util.LinkedHashMap$LinkedValueIterator.next(LinkedHashMap.java:1052) ~[?:?]
at net.minecraft.commands.Commands.fillUsableCommands(Commands.java:536) ~[paper-1.20.6.jar:1.20.6-115-9d6f2cc]
at net.minecraft.commands.Commands.sendAsync(Commands.java:495) ~[paper-1.20.6.jar:1.20.6-115-9d6f2cc]
at net.minecraft.commands.Commands.lambda$sendCommands$6(Commands.java:474) ~[paper-1.20.6.jar:1.20.6-115-9d6f2cc]
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?]
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?]
at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]

Expected Behavior

No Error

Steps to Reproduce

/skript reload

Errors or Screenshots

[11:20:01 ERROR]: Caught previously unhandled exception :
[11:20:01 ERROR]: Paper Async Command Builder Thread Pool - 0
java.util.ConcurrentModificationException: null
at java.base/java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:1023) ~[?:?]
at java.base/java.util.LinkedHashMap$LinkedValueIterator.next(LinkedHashMap.java:1052) ~[?:?]
at net.minecraft.commands.Commands.fillUsableCommands(Commands.java:536) ~[paper-1.20.6.jar:1.20.6-115-9d6f2cc]
at net.minecraft.commands.Commands.sendAsync(Commands.java:495) ~[paper-1.20.6.jar:1.20.6-115-9d6f2cc]
at net.minecraft.commands.Commands.lambda$sendCommands$6(Commands.java:474) ~[paper-1.20.6.jar:1.20.6-115-9d6f2cc]
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?]
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?]
at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@sovdeeth
Copy link
Member

Can you recreate this without addons?

@sovdeeth sovdeeth added the waiting for reply The report needs a response from the reporter to determine course of action. label May 28, 2024
@ShaneBeee
Copy link
Contributor

ShaneBeee commented Jun 2, 2024

  1. I can confirm this with no addons

  2. this error is something SkBriggy had a while back (due to registering vanilla MC type commands with Command API).
    And it's now something that happens in Paper due to paper doing some internal changes with their command api and how commands are registered internally.
    I THINK it's something to do with unregistering then re-registering commands when reloading a script.

@sovdeeth sovdeeth added investigating The core developers are currently investigating this issue. Usually used for complex cases. and removed waiting for reply The report needs a response from the reporter to determine course of action. labels Jun 2, 2024
@APickledWalrus APickledWalrus self-assigned this Jun 3, 2024
@APickledWalrus APickledWalrus added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. and removed investigating The core developers are currently investigating this issue. Usually used for complex cases. labels Jun 3, 2024
@APickledWalrus APickledWalrus added PR available Issues which have a yet-to-be merged PR resolving it labels Jun 3, 2024
@veeonthewall
Copy link

Happened to me too. Skript 2.8.6, SkBee 3.5.2, skript-reflect 2.4. Paper 1.20.6
Screenshot 2024-06-04 at 8 51 40 PM

@sovdeeth sovdeeth added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Jun 6, 2024
@APickledWalrus APickledWalrus added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.
Projects
None yet
Development

No branches or pull requests

5 participants