Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reset the selected values for a variable when it's parent variable changes #5322

Open
srikanthccv opened this issue Jun 24, 2024 · 1 comment

Comments

@srikanthccv
Copy link
Member

Imagine you are looking at a service metrics dashboard for an env staging and you want to see the same for different env prod, now if you change the deployment_environment variable to prod all the dependent variable selection gets reset to ALL. This can be an annoying experience because I have to make the same selection as earlier.

Should we not reset all the times or should we not reset only when the newly fetched values have the previous selection as a subset? i.e only reset the service_name if the result of service_name for new env returns a set that has no common values in current selected value?

@srikanthccv
Copy link
Member Author

  1. Ability to type the custom value. The value should be applied on the enter key or move the mouse out
    • For single select only one value
    • For multi-select, more than one value
  2. Push the selected values to the top
  3. Do not close the dropdown for multi-select after the first selection
  4. Separate ALL from the rest of the options.
  5. One should be able to select multiple at the same on the first load. Right now ALL is enabled by default and one can’t go about selecting more than one.
  6. Do not reset the filter to default when the response already contains the selected values i.e. keep the existing values chosen if they are also present in the response.
  7. Be able to clear the selection
  8. Easy to edit mode when the number of selected values is high
  9. The sequence of the queries is not going to go away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant