Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JwtLexik listener for onsuccess & onfailure instead of my object #120

Open
Rebolon opened this issue Feb 15, 2019 · 2 comments
Open

Comments

@Rebolon
Copy link
Owner

Rebolon commented Feb 15, 2019

Take care, for instance the project has API route protected with jwt and some are free like Get on book
So test before validate the change

@Rebolon Rebolon changed the title Use JwtLexik listener for onsuccess & onfailure instead of min object Use JwtLexik listener for onsuccess & onfailure instead of my object Mar 18, 2019
@Rebolon
Copy link
Owner Author

Rebolon commented Mar 18, 2019

In fact when i use JwtLexikListener then all routes managed by this listener are protected and require a valid Jwt token. I don't find a way for instance to allow anonymous route on the same firewall.

My own listener works well, so i don't know if it's a good practice or if i'm going wrong. I will look further on JwtLexik repo

@Rebolon
Copy link
Owner Author

Rebolon commented May 20, 2019

@todo one thing that coud be certainly removed is the LoginJwtController::token method and use json_login security with success/failure handlers this is a really better practice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant