Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use patch bundle manifest name by default #1980

Open
3 tasks done
oSumAtrIX opened this issue Jun 22, 2024 · 7 comments
Open
3 tasks done

feat: Use patch bundle manifest name by default #1980

oSumAtrIX opened this issue Jun 22, 2024 · 7 comments
Assignees
Labels
Feature request Requesting a new feature that's not implemented yet ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager

Comments

@oSumAtrIX
Copy link
Member

Feature description

Main should probably be renamed to "Default". A description for the bundle can also be present or in the bundle screen that says "This is the default bundle that comes with the configured API in the settings".

image

Motivation

Main doesn't really say much

Acknowledgements

  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • The feature request is only related to ReVanced Manager
@oSumAtrIX oSumAtrIX added Feature request Requesting a new feature that's not implemented yet ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager labels Jun 22, 2024
@Ushie Ushie self-assigned this Jun 23, 2024
@Ushie
Copy link
Member

Ushie commented Jun 25, 2024

I got an idea for this

The ReVanced API has an info endpoint, what's stopping us from using the name from there for the patch bundle?

${apiName} Bundle would work good

@Ushie Ushie reopened this Jun 25, 2024
@oSumAtrIX
Copy link
Member Author

That makes sense, so you use the domain. In ReVanceds case it would be revanced.app. But what if we host two bundles? Or say, people do it on GitHub?

@Ushie
Copy link
Member

Ushie commented Jun 25, 2024

This is for the API based bundle, for standalone bundle, the user has to input a name for it anyways

Default is not very much of a name, nor was main
No, I wasn't suggesting using the domain, I was suggesting to use https://api.revanced.app/v2/info

@oSumAtrIX
Copy link
Member Author

I see, that sounds reasonable

@indrastorms
Copy link

This is for the API based bundle, for standalone bundle, the user has to input a name for it anyways

Manually putting name is so annoying, why manager can't read the name from bundle's manifest?

@Ushie Ushie changed the title feat: Rename "Main" bundle feat: Use patch bundle manifest name by default Jun 26, 2024
@Ushie
Copy link
Member

Ushie commented Jun 26, 2024

Yeah that makes sense, ReVanced Manager can populate the name with the bundle's manifest, and allow the user to edit it if they want

@oSumAtrIX
Copy link
Member Author

This also makes more sense in the case of the API based bundle.

@Axelen123 Axelen123 added this to the ReVanced Manager (Compose) milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
Status: No status
Development

No branches or pull requests

5 participants