-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of deprecated module audioop #9477
Comments
Yeah I know. When they voted to deprecated I voiced my concerns but I was more or less ignored. I'm unsure what to do going forward, it can't be in Python because this is low latency. |
Maintaining |
I actually already began work on this. I just need to wait for a less-than-alpha 3.13 release to test the build and CI. |
I believe this is ready for testing before signing off. |
… (This bot needs to stay with 3.12 for now): "Use of deprecated module audioop": Rapptz/discord.py#9477 - Have setup.sh wipe out the old .venv folder before creating it again from scratch - This helps with major upgrades of Python - Unpinned the Python dependencies - This will help cope with random dependabot security pull requests - Use python development dependencies (ie. black, pylint) if specified by requirements-dev.txt - If we detect a running systemd or docker bot instance, do a restart instead of a start - Standardized naming of systemd service references to use underscores only, rather than a mix of dashes and underscores - Parameterized naming of systemd service and Docker container in the install scripts
… (This bot needs to stay with 3.12 for now): "Use of deprecated module audioop": Rapptz/discord.py#9477 (#11) - Have setup.sh wipe out the old .venv folder before creating it again from scratch - This helps with major upgrades of Python - Unpinned the Python dependencies - This will help cope with random dependabot security pull requests - Use python development dependencies (ie. black, pylint) if specified by requirements-dev.txt - If we detect a running systemd or docker bot instance, do a restart instead of a start - Standardized naming of systemd service references to use underscores only, rather than a mix of dashes and underscores - Parameterized naming of systemd service and Docker container in the install scripts Co-authored-by: Tom Zacharoff <[email protected]>
Summary
discord.py uses the audioop module which will be removed in Python 3.13
Reproduction Steps
On Python 3.11:
python -Walways -c "import discord"
Output:
System Information
Additional Context
The only usage is here:
discord.py/discord/player.py
Line 633 in 0871b34
There doesn't seem to be any standard library alternative, or external library that I can obviously see. It's been a while since it was deprecated so I'm not sure how much chance there is someone will turn it into an external library.
One option could be to try and reimplement it in Python, which seems like it could be doable as it doesn't seem too complicated: https://github.com/python/cpython/blob/036da3bd43aa2593d17d2fb73d4794f9965c577d/Modules/audioop.c#L944, not really sure though.
The text was updated successfully, but these errors were encountered: