Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option Exercise Consistency #8050

Open
4 tasks done
AlexCatarino opened this issue May 23, 2024 · 2 comments
Open
4 tasks done

Option Exercise Consistency #8050

AlexCatarino opened this issue May 23, 2024 · 2 comments
Labels

Comments

@AlexCatarino
Copy link
Member

Expected Behavior

Options are exercised with the same underlying price whether we subscribe to extended hours or not.

Actual Behavior

The exercised price is different.

Order Tab

Potential Solution

Do not use prices outside the market hours.

Reproducing the Problem

backtest_1401e01, use extended_market_hours=False for different results.

Checklist

  • I have completely filled out this template
  • I have confirmed that this issue exists on the current master branch
  • I have confirmed that this is not a duplicate issue by searching issues
  • I have provided detailed steps to reproduce the issue
@MarcellThoth
Copy link

Thanks Alex! This is a significant issue, please fix it asap.

@Martin-Molinero
Copy link
Member

The option is getting exercised when it's delisted, BacktestingBrokerage->OptionNotificationEventArgs->BTH->HandleOptionNotification. There are a couple of side effects I can see, (A) OptionPortfolioModel if SettlementType.Cash it's using the underlying.Close to calculate cash & DefaultExerciseModel using underlying.Close to determine if ITM or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants