Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use user-specified library search paths in RUSTFLAGS in auditwheel #2096

Open
messense opened this issue Jun 4, 2024 · 1 comment
Open
Labels
enhancement New feature or request good first issue Good for newcomers wheel Wheel

Comments

@messense
Copy link
Member

messense commented Jun 4, 2024

Probably because when repair the wheel maturin only tries paths from <target>-gcc --print-sysroot and linked_paths of cargo build script, it does not take -L options in rust flags into consideration yet.

Originally posted by @messense in #2092 (comment)

@messense messense added enhancement New feature or request wheel Wheel labels Jun 4, 2024
@messense
Copy link
Member Author

messense commented Jun 4, 2024

We can use the rustflags crate to parse rustflags from cargo-config2 and add the additional libary search paths here:

let ld_paths = artifact.linked_paths.iter().map(PathBuf::from).collect();
let external_libs = find_external_libs(&artifact.path, &policy, sysroot, ld_paths)

@messense messense added the good first issue Good for newcomers label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers wheel Wheel
Projects
None yet
Development

No branches or pull requests

1 participant