Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Maturin's wheel contains two copies of LICENSE when using license-file in workspace crate Cargo.toml #2066

Closed
1 of 2 tasks
HerringtonDarkholme opened this issue May 3, 2024 · 0 comments · Fixed by #2125
Assignees
Labels
bug Something isn't working

Comments

@HerringtonDarkholme
Copy link
Contributor

HerringtonDarkholme commented May 3, 2024

Bug Description

I'm using carge workspace to publish my project.

The main CLI project uses license-file to include a license file for downstream packager. ast-grep/ast-grep#473

However, this makes maturin includes two copies of LICENSE. ast-grep/ast-grep#766

image

Your maturin version (maturin --version)

0.15.0

Your Python version (python -V)

3.10

Your pip version (pip -V)

23.3.1

What bindings you're using

bin

Does cargo build work?

  • Yes, it works

If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash /)?

  • Yes

Steps to Reproduce

  1. Crates.toml
[package]
name = "ast-grep"
license-file = "../../LICENSE"
  1. pyproject.toml in root directory
[project]
name = "ast-grep-cli"
[tool.maturin]
bindings = "bin"
manifest-path = "crates/cli/Cargo.toml"
  1. build
maturin build
  1. examine the wheel
unzip -l target/wheels/ast_grep_cli.whl

Example repo:

https://github.com/ast-grep/ast-grep

@HerringtonDarkholme HerringtonDarkholme added the bug Something isn't working label May 3, 2024
@konstin konstin self-assigned this Jun 27, 2024
konstin added a commit that referenced this issue Jun 27, 2024
Add a file tracker for writing archives that checks that each path in the archive can't be added more than once. If the same file would be added twice, it's ignored the second time, if a different file would be added, it errors.

Fixes #2066
Fixes #2106
konstin added a commit that referenced this issue Jun 27, 2024
Add a file tracker for writing archives that checks that each path in the archive can't be added more than once. If the same file would be added twice, it's ignored the second time, if a different file would be added, it errors.

Fixes #2066
Fixes #2106
konstin added a commit that referenced this issue Jun 27, 2024
Add a file tracker for writing archives that checks that each path in the archive can't be added more than once. If the same file would be added twice, it's ignored the second time, if a different file would be added, it errors.

Fixes #2066
Fixes #2106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants