Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNOME 45 Support #200

Open
craftergarage opened this issue Sep 1, 2023 · 15 comments
Open

GNOME 45 Support #200

craftergarage opened this issue Sep 1, 2023 · 15 comments

Comments

@craftergarage
Copy link

GNOME 45 is in beta now, Please add support for it to ensure compatibility with the latest version of GNOME and provide users with access to new features and improvements.

@debianmain1
Copy link

Really like this & am wondering about the timeline for a 45-capable version?

@debianmain1
Copy link

I just updated to 45 in Arch via extra-testing...it's working flawlessly---just waiting for this extension to complete my extensions.

@craftergarage
Copy link
Author

This is good news :)

@butterdori
Copy link

Yes, pretty please! This is the best screenshot tool for GNOME.

@sagitariozod
Copy link

JS ERROR: Extension [email protected]: SyntaxError: import declarations may only appear at top level of a module @ resource:///org/gnome/shell/misc/extensionUtils.js:4:0

@oxayotl
Copy link
Contributor

oxayotl commented Oct 23, 2023

I'm working on updating the extension for Gnome Shell 45. As soon as I get it everything to work I'll create a pull request.

@oxayotl
Copy link
Contributor

oxayotl commented Oct 24, 2023

Okay I think I kinda messed up and edited some generated JS files instead of editing the actual typescript files. I think. I'm not very sure.
Anyway you can check it out here and see if it works well:
https://choum.net/JA/[email protected]
It still has some few issues, for instance I had to add a dot next to the screen capture duration scroller or else it wouldn't show.
I'll try to learn typescript and understand how the compilation tools work and make a better update in the future :) .

@sagitariozod
Copy link

Thank you very much for the update, it works well, although if I leave the session, without closing it, and come back in, it always shows me the settings screen, it's not a big problem, I close it and that's it.
We wait for the next update.
Thank you very much for your time.

@zrno
Copy link

zrno commented Nov 15, 2023

any news?

@OttoAllmendinger
Copy link
Owner

OttoAllmendinger commented Nov 16, 2023

Gnome 45 introduced a bunch of breaking changes, a proper upgrade will take a few months

Okay I think I kinda messed up and edited some generated JS files instead of editing the actual typescript files

@oxayotl Thank you, this is still useful for me! I will look into doing a one-time JS release of the extension

@oxayotl
Copy link
Contributor

oxayotl commented Nov 20, 2023

Great, thanks!!!

@Jerther
Copy link

Jerther commented Nov 24, 2023

@oxayotl I just tested your version and I'm able to take screenshots! Thank you! 😄

For those who might need help:
1- Uninstall outdated version
2- unzip oxayotl's version
3- move the unzipped folder into ~/.local/share/gnome-shell/extensions/
4- Log out, then back in.

@jmaargh
Copy link

jmaargh commented Dec 12, 2023

@oxayotl Any word on that PR? Or do you have a fork with the changes so I can make a PR?

@oxayotl
Copy link
Contributor

oxayotl commented Dec 13, 2023

@jmaargh I edited the generated javascript instead of the original typescript, so I cannot really make a PR. The files I edited don't exist in the repo. I couldn't figure out how the original typescript files were merged into one and I needed to make changes to that part (the “import” declarations have to be at the top of the file now), so I gave up.

@OttoAllmendinger
Copy link
Owner

OttoAllmendinger commented Dec 26, 2023

latest commit on master has support for Gnome 45

new version is pending review on e.g.o

happy holidays! 🎄 🎅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants