Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove assumptions about same-origin runtime. #32

Open
theengineear opened this issue Nov 4, 2023 · 0 comments
Open

Remove assumptions about same-origin runtime. #32

theengineear opened this issue Nov 4, 2023 · 0 comments

Comments

@theengineear
Copy link
Collaborator

The general architecture for x-test uses postMessage everywhere — which is perfectly fine for cross-origin environments. However, there are a couple assumptions that may need to be double-checked / changed.

Here are a handful of things to check / change:

  • Access to frameElement — The docs suggest that when loaded cross-origin, this will always be null. That would shunt off how we pass information from parent to child for identifiers.
  • Access to top. This seems to be ok, but it’s a fairly blunt tool for what we need.

One thing we might do is Demeter this thing and limit parent-child comms to single-use, private MessageChannel ports. It would essentially change from a common bus architecture to more like a forwarding pyramid architecture. It’d be worth investigating.
theengineear added a commit that referenced this issue Jun 14, 2024
@theengineear
Improve root test detection.
cf54ed9 
Previously, we looked for a “frameElement.id” property to determine if
a document running tests was the “root” test runner or not.

This was too naive as it assumes that integrators looking to iframe a
test suite into a part of a parent application _won’t_ set an “id”
property / attribute on that iframe.

Instead, we now use a “data-*” attribute with a namespace:

```
data-x-test-test-id
```

See #32.
@theengineear theengineear mentioned this issue Jun 14, 2024
Merged
theengineear added a commit that referenced this issue Jun 14, 2024
@theengineear
Improve root test detection.
a544b36 
Previously, we looked for a “frameElement.id” property to determine if
a document running tests was the “root” test runner or not.

This was too naive as it assumes that integrators looking to iframe a
test suite into a part of a parent application _won’t_ set an “id”
property / attribute on that iframe.

Instead, we now use a “data-*” attribute with a namespace:

```
data-x-test-test-id
```

See #32.
theengineear added a commit that referenced this issue Jun 14, 2024
@theengineear
Improve root test detection.
01f8ece 
Previously, we looked for a “frameElement.id” property to determine if
a document running tests was the “root” test runner or not.

This was too naive as it assumes that integrators looking to iframe a
test suite into a part of a parent application _won’t_ set an “id”
property / attribute on that iframe.

Instead, we now use a “data-*” attribute with a namespace:

```
data-x-test-test-id
```

See #32.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theengineear