Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: scalar coercing exceptions don't use typed graphql error #1914

Open
Meemaw opened this issue May 19, 2024 · 1 comment
Open

bug: scalar coercing exceptions don't use typed graphql error #1914

Meemaw opened this issue May 19, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Meemaw
Copy link

Meemaw commented May 19, 2024

Expected behavior

TypedGraphQLError is used consistently across all error surfaces.

Actual behavior

When using custom scalar, coercing exceptions (e.g CoercingParseLiteralException) don't use the TypedGraphQLError and provide very bare-bones errors.

This was improved in 8.6.0 for some validation errors, but custom scalar coercing was missed.

Steps to reproduce

Note: A test case would be highly appreciated, but we understand that's not always possible

@Meemaw Meemaw added the bug Something isn't working label May 19, 2024
@srinivasankavitha
Copy link
Contributor

Thanks for flagging this. We'll fix this behavior in the next release or two .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants