Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove profile value passing #279

Open
aaronchantrill opened this issue Jun 26, 2020 · 1 comment
Open

Remove profile value passing #279

aaronchantrill opened this issue Jun 26, 2020 · 1 comment
Labels
Good First Issue! Hacktoberfest Small or non-core issues that could be worked on by Hacktoberfest participants Priority: Low Status: Available Type: Maintenance

Comments

@aaronchantrill
Copy link
Contributor

aaronchantrill commented Jun 26, 2020

Detailed Description

There are a lot of places that expect the configuration to be passed in as a structure. Now that the configuration is stored in a public static module, it is no longer necessary to pass the values from module to module, but a lot of modules expect a copy of the config/profile to be passed in. This adds extra complexity to the code and confusion about the "proper" way to access profile values.

Context

This change is just to reduce complexity and increase readability.

Possible Implementation

The implementation is simple. Simply remove every reference to config. from the existing codebase and replace them with profile.get(, default), then remove every place that a module is specifically waiting for or passing a config.

This is pretty simple and would be a good way for someone to learn something about the structure of the code base. I am happy to provide additional support. Unfortunately, this is one of those projects that makes minor changes to a lot of files in this project.

@aaronchantrill aaronchantrill added the Hacktoberfest Small or non-core issues that could be worked on by Hacktoberfest participants label Aug 30, 2020
@AustinCasteel AustinCasteel added this to New Issues in Core Development Aug 30, 2020
@Pratikdate
Copy link

Assign me i will work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue! Hacktoberfest Small or non-core issues that could be worked on by Hacktoberfest participants Priority: Low Status: Available Type: Maintenance
Projects
Development

No branches or pull requests

2 participants