{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":42009758,"defaultBranch":"develop","name":"metamask-extension","ownerLogin":"MetaMask","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-09-06T16:34:48.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/11744586?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1719615704.0","currentOid":""},"activityList":{"items":[{"before":"12731a11196bb89901f57bae160b1e2c7c2ca033","after":"c3d38b8c6aa4d14b05db2e750460bc8986c5073c","ref":"refs/heads/fix-issue-25285","pushedAt":"2024-06-28T23:30:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ejwessel","name":"Ethan Wessel","path":"/ejwessel","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3590816?s=80&v=4"},"commit":{"message":"chore: lint fixes","shortMessageHtmlLink":"chore: lint fixes"}},{"before":"bc40433709ef63dba3a8f19fd72a34491f163416","after":"12731a11196bb89901f57bae160b1e2c7c2ca033","ref":"refs/heads/fix-issue-25285","pushedAt":"2024-06-28T23:27:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ejwessel","name":"Ethan Wessel","path":"/ejwessel","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3590816?s=80&v=4"},"commit":{"message":"chore: lint fix","shortMessageHtmlLink":"chore: lint fix"}},{"before":"ebfdad2372bd3d8fe4cc047e337c241bfe5de2fb","after":"bc40433709ef63dba3a8f19fd72a34491f163416","ref":"refs/heads/fix-issue-25285","pushedAt":"2024-06-28T23:24:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ejwessel","name":"Ethan Wessel","path":"/ejwessel","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3590816?s=80&v=4"},"commit":{"message":"chore: fix tests","shortMessageHtmlLink":"chore: fix tests"}},{"before":"ef60531fd3984cf9c597b9841b1ce866a63038a9","after":"a0cf35976afc3980fed723f19521fea365c97144","ref":"refs/heads/webpack-dm-rebased","pushedAt":"2024-06-28T23:15:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"davidmurdoch","name":"David Murdoch","path":"/davidmurdoch","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/187813?s=80&v=4"},"commit":{"message":"update link to completion PR","shortMessageHtmlLink":"update link to completion PR"}},{"before":"dd6fd559f0524b2e021043c7f3040712976e228c","after":"801e177122800e4ffd1c4d9d973e7274a7c1f976","ref":"refs/heads/feat/transaction-data-decode","pushedAt":"2024-06-28T23:10:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"matthewwalsh0","name":"Matthew Walsh","path":"/matthewwalsh0","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19745142?s=80&v=4"},"commit":{"message":"Fix uniswap path rendering","shortMessageHtmlLink":"Fix uniswap path rendering"}},{"before":null,"after":"d2853753b9382d8a989ac140fc915b5ab0f73332","ref":"refs/heads/multichain-switch-network-dapp-test","pushedAt":"2024-06-28T23:01:44.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"darkwing","name":"David Walsh","path":"/darkwing","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46655?s=80&v=4"},"commit":{"message":"test: UX: Multichain: Add E2E for signaling network change from Network menu to dapp","shortMessageHtmlLink":"test: UX: Multichain: Add E2E for signaling network change from Netwo…"}},{"before":"1ec69eac01fa240be84d2eb0d8c8dbc212991e3e","after":"dd6fd559f0524b2e021043c7f3040712976e228c","ref":"refs/heads/feat/transaction-data-decode","pushedAt":"2024-06-28T22:58:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"matthewwalsh0","name":"Matthew Walsh","path":"/matthewwalsh0","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19745142?s=80&v=4"},"commit":{"message":"Fix transaction data stories","shortMessageHtmlLink":"Fix transaction data stories"}},{"before":"dd2089d70834da7d3847e9a38847238d4d0239e6","after":"1833c483b1a71ddbb1358f2a709eab9ae402b196","ref":"refs/heads/mb867-bridge-feature-flagged-route","pushedAt":"2024-06-28T22:53:44.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"micaelae","name":null,"path":"/micaelae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/100321200?s=80&v=4"},"commit":{"message":"test: add bridge e2e tests for routing","shortMessageHtmlLink":"test: add bridge e2e tests for routing"}},{"before":"7577e6e24bb19067522c28bbd564cf9ed5b2a4f3","after":"6c6d3f7cdba371d8b3ec1a1a3a770da952c8703f","ref":"refs/heads/mb866-bridge-input-actions","pushedAt":"2024-06-28T22:45:27.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"micaelae","name":null,"path":"/micaelae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/100321200?s=80&v=4"},"commit":{"message":"chore: add from/to inputs to PrepareBridge page","shortMessageHtmlLink":"chore: add from/to inputs to PrepareBridge page"}},{"before":"fff204035d3eb13d0cdea3433832afcc92544c81","after":"a3d56810aab9765d8654cfd5dd8d34ab6f3d5129","ref":"refs/heads/e2e-snap-account-swap","pushedAt":"2024-06-28T22:43:12.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"plasmacorral","name":"Mike B","path":"/plasmacorral","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32695229?s=80&v=4"},"commit":{"message":"Merge branch 'develop' into e2e-snap-account-swap","shortMessageHtmlLink":"Merge branch 'develop' into e2e-snap-account-swap"}},{"before":"8c69f46c1c943c4f1b5bf6c5558eeb1a829c6c32","after":"03a799268e066e66dde3da5150601a844f3698bf","ref":"refs/heads/l10n_crowdin_action","pushedAt":"2024-06-28T22:43:10.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"New Crowdin translations by Github Action","shortMessageHtmlLink":"New Crowdin translations by Github Action"}},{"before":"0485474001544ea22e02266fe96ccc6d90066612","after":null,"ref":"refs/heads/bump-assets-and-transaction-controllers","pushedAt":"2024-06-28T22:42:10.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"plasmacorral","name":"Mike B","path":"/plasmacorral","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32695229?s=80&v=4"}},{"before":"58082f542b950f979ac362d7aa428f8181e80b9b","after":"f353f0c316a18510a71ac3c4d45b765f78475028","ref":"refs/heads/develop","pushedAt":"2024-06-28T22:42:08.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"plasmacorral","name":"Mike B","path":"/plasmacorral","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32695229?s=80&v=4"},"commit":{"message":"chore(deps): bump assets controller to v34.0.0 (#25540)\n\n\r\n\r\n## **Description**\r\n\r\n\r\n\r\nThis PR bumps `@metamask/assets-controllers` to `^34.0.0`.\r\n## **Related issues**\r\n\r\nFixes https://github.com/MetaMask/accounts-planning/issues/481\r\n\r\n## **Manual testing steps**\r\n\r\nThis PR affects all assets related tokens\r\n\r\n1. Test added and removing of and tokens\r\n2. Transfer tokens\r\n3. Turn on off token detection and see the detected tokens\r\n4. Check if the token rate values on mainnet\r\n\r\n## **Screenshots/Recordings**\r\n\r\n\r\n\r\n### **Before**\r\n\r\n\r\n\r\n### **After**\r\n\r\n\r\n\r\n## **Pre-merge author checklist**\r\n\r\n- [ ] I've followed [MetaMask Contributor\r\nDocs](https://github.com/MetaMask/contributor-docs) and [MetaMask\r\nExtension Coding\r\nStandards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).\r\n- [ ] I've completed the PR template to the best of my ability\r\n- [ ] I’ve included tests if applicable\r\n- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format\r\nif applicable\r\n- [ ] I’ve applied the right labels on the PR (see [labeling\r\nguidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).\r\nNot required for external contributors.\r\n\r\n## **Pre-merge reviewer checklist**\r\n\r\n- [x] I've manually tested the PR (e.g. pull and build branch, run the\r\napp, test code being changed).\r\n- [x] I confirm that this PR addresses all acceptance criteria described\r\nin the ticket it closes and includes the necessary testing evidence such\r\nas recordings and or screenshots.\r\n\r\n---------\r\n\r\nCo-authored-by: MetaMask Bot ","shortMessageHtmlLink":"chore(deps): bump assets controller to v34.0.0 (#25540)"}},{"before":"e051de582993ddb1a9e3b0942f837cb084a82317","after":"a79c90ba63eca60f4ba84feb5c897eda9141bdb6","ref":"refs/heads/jl/caip-multichain/verify-scope-method","pushedAt":"2024-06-28T22:41:35.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"jiexi","name":null,"path":"/jiexi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/918701?s=80&v=4"},"commit":{"message":"Merge branch 'jl/mmp-2360/caip-25-poc' into jl/caip-multichain/verify-scope-method","shortMessageHtmlLink":"Merge branch 'jl/mmp-2360/caip-25-poc' into jl/caip-multichain/verify…"}},{"before":"819fde5c745d6b8d838336c6dd84a9f5d571f31a","after":"8be9eae6cc1429f6329e1c48c53b1e1785b0cdbc","ref":"refs/heads/jl/mmp-2360/caip-25-poc","pushedAt":"2024-06-28T22:41:33.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"jiexi","name":null,"path":"/jiexi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/918701?s=80&v=4"},"commit":{"message":"Merge branch 'develop' into jl/mmp-2360/caip-25-poc","shortMessageHtmlLink":"Merge branch 'develop' into jl/mmp-2360/caip-25-poc"}},{"before":"98a10b9cee425de2583080cf990c84abaa3b741d","after":"dd2089d70834da7d3847e9a38847238d4d0239e6","ref":"refs/heads/mb867-bridge-feature-flagged-route","pushedAt":"2024-06-28T22:41:19.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"micaelae","name":null,"path":"/micaelae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/100321200?s=80&v=4"},"commit":{"message":"test: add bridge e2e tests for routing","shortMessageHtmlLink":"test: add bridge e2e tests for routing"}},{"before":"4a47ea25c0b20ae96c2fef21bdf59f51564e10b3","after":"98a10b9cee425de2583080cf990c84abaa3b741d","ref":"refs/heads/mb867-bridge-feature-flagged-route","pushedAt":"2024-06-28T22:32:28.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"micaelae","name":null,"path":"/micaelae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/100321200?s=80&v=4"},"commit":{"message":"test: add bridge e2e tests for routing","shortMessageHtmlLink":"test: add bridge e2e tests for routing"}},{"before":"7f081cfa366c02eb3207b66341b1ec4d78d521bd","after":"2d1ec41ce50acc9fc25e68c60bbd4710143d94bf","ref":"refs/heads/feat/define-account-name-during-creation","pushedAt":"2024-06-28T22:24:43.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"k-g-j","name":"Kate Johnson","path":"/k-g-j","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91970214?s=80&v=4"},"commit":{"message":"Merge branch 'develop' into feat/define-account-name-during-creation","shortMessageHtmlLink":"Merge branch 'develop' into feat/define-account-name-during-creation"}},{"before":"3ec54036c8ab32827e1aa09e8aabc4b202ec8040","after":"4a47ea25c0b20ae96c2fef21bdf59f51564e10b3","ref":"refs/heads/mb867-bridge-feature-flagged-route","pushedAt":"2024-06-28T22:22:42.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"micaelae","name":null,"path":"/micaelae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/100321200?s=80&v=4"},"commit":{"message":"test: add bridge e2e tests for routing","shortMessageHtmlLink":"test: add bridge e2e tests for routing"}},{"before":"b512e4a3ca8ccf98d94dfb882affedfda01ad557","after":"1ec69eac01fa240be84d2eb0d8c8dbc212991e3e","ref":"refs/heads/feat/transaction-data-decode","pushedAt":"2024-06-28T22:20:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"matthewwalsh0","name":"Matthew Walsh","path":"/matthewwalsh0","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19745142?s=80&v=4"},"commit":{"message":"Add unit test for expandable row","shortMessageHtmlLink":"Add unit test for expandable row"}},{"before":"10a395ee749c39aeeb99c1c797466e673df14316","after":"7577e6e24bb19067522c28bbd564cf9ed5b2a4f3","ref":"refs/heads/mb866-bridge-input-actions","pushedAt":"2024-06-28T22:17:22.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"micaelae","name":null,"path":"/micaelae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/100321200?s=80&v=4"},"commit":{"message":"chore: add from/to inputs to PrepareBridge page","shortMessageHtmlLink":"chore: add from/to inputs to PrepareBridge page"}},{"before":"3f24c3385b2575432160b77d4281601c71e0c1ec","after":"b512e4a3ca8ccf98d94dfb882affedfda01ad557","ref":"refs/heads/feat/transaction-data-decode","pushedAt":"2024-06-28T22:14:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"matthewwalsh0","name":"Matthew Walsh","path":"/matthewwalsh0","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19745142?s=80&v=4"},"commit":{"message":"Add unit tests for decode hook","shortMessageHtmlLink":"Add unit tests for decode hook"}},{"before":"c15ed5242bfe2dcdb605a80efaa500385b41374c","after":"3ec54036c8ab32827e1aa09e8aabc4b202ec8040","ref":"refs/heads/mb867-bridge-feature-flagged-route","pushedAt":"2024-06-28T22:11:10.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"micaelae","name":null,"path":"/micaelae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/100321200?s=80&v=4"},"commit":{"message":"test: add bridge e2e tests for routing","shortMessageHtmlLink":"test: add bridge e2e tests for routing"}},{"before":"dacaf50e1ce8edb27e34e859a9dd0bcd9263dfad","after":"ebfdad2372bd3d8fe4cc047e337c241bfe5de2fb","ref":"refs/heads/fix-issue-25285","pushedAt":"2024-06-28T22:10:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ejwessel","name":"Ethan Wessel","path":"/ejwessel","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3590816?s=80&v=4"},"commit":{"message":"chore: hide max button when src token is native and the destination token is different","shortMessageHtmlLink":"chore: hide max button when src token is native and the destination t…"}},{"before":"9056682b4c484c6a9984a28bca74803036faba92","after":"10a395ee749c39aeeb99c1c797466e673df14316","ref":"refs/heads/mb866-bridge-input-actions","pushedAt":"2024-06-28T21:49:43.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"micaelae","name":null,"path":"/micaelae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/100321200?s=80&v=4"},"commit":{"message":"chore: add from/to inputs to PrepareBridge page","shortMessageHtmlLink":"chore: add from/to inputs to PrepareBridge page"}},{"before":"e51373f15591f1ca8f2da60540e822e49b1fe947","after":"9056682b4c484c6a9984a28bca74803036faba92","ref":"refs/heads/mb866-bridge-input-actions","pushedAt":"2024-06-28T21:49:09.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"micaelae","name":null,"path":"/micaelae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/100321200?s=80&v=4"},"commit":{"message":"chore: add from/to inputs to PrepareBridge page","shortMessageHtmlLink":"chore: add from/to inputs to PrepareBridge page"}},{"before":"c88499b7dd3eb84f79f4578d1443923b2ae06ef1","after":"c15ed5242bfe2dcdb605a80efaa500385b41374c","ref":"refs/heads/mb867-bridge-feature-flagged-route","pushedAt":"2024-06-28T21:48:01.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"micaelae","name":null,"path":"/micaelae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/100321200?s=80&v=4"},"commit":{"message":"test: add bridge e2e tests for routing","shortMessageHtmlLink":"test: add bridge e2e tests for routing"}},{"before":null,"after":"6077c42e4aa27fd0dd63b5dedaa9a745fdd62ab0","ref":"refs/heads/Version-v12.0.0-fix-eth_signTypedData-correct-network-on-confirmation","pushedAt":"2024-06-28T21:47:44.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"adonesky1","name":"Alex Donesky","path":"/adonesky1","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/34557516?s=80&v=4"},"commit":{"message":"fix: add eth_signTypedData and eth_signTypedData_v3 to `methodsRequiringNetworkSwitch` (#25562)\n\n## **Description**\r\n\r\nThough signature requests like `personal_sign`, `eth_signTypedData`,\r\n`eth_signTypedData_v3` and `eth_signTypedData_v4` do not depend on state\r\nof network connections, these confirmations do use nicknames/addressbook\r\nstate which is dependent on globally selected network state for parsing\r\nsignatures and injecting nicknaming where possible. The queueing system\r\nintroduced with Amon Hen v1 (v12.0.0 release) introduces certain\r\nconditions in which these signature confirmations will be rendered on\r\nthe wrong network. Though this doesn't actually result in faulty\r\nsignatures, we should switch to the appropriate/expected network for the\r\nUX reasons described above. Adding `eth_signTypedData_v3` and\r\n`eth_signTypedData` to the `methodsRequiringNetworkSwitch` array will\r\ncause the network to switch to the selected network for the requesting\r\norigin before initializing the confirmation.\r\n\r\n[![Open in GitHub\r\nCodespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25562?quickstart=1)\r\n\r\n## **Related issues**\r\n\r\nFixes: https://github.com/MetaMask/metamask-extension/issues/25528\r\nSee this slack thread:\r\nhttps://consensys.slack.com/archives/C06FXU326RL/p1719429561925649?thread_ts=1719415715.492249&cid=C06FXU326RL\r\n## **Manual testing steps**\r\n See videos below 👇 \r\n\r\n## **Screenshots/Recordings**\r\n\r\n\r\n\r\n### **Before**\r\n\r\n\r\n\r\n\r\nhttps://github.com/MetaMask/metamask-extension/assets/34557516/3e32fce7-046c-4856-893d-a85083877327\r\n\r\n\r\n### **After**\r\n\r\n\r\n\r\n\r\nhttps://github.com/MetaMask/metamask-extension/assets/34557516/306d88aa-f5f3-4eae-a8e9-30b621c02626\r\n\r\n\r\n## **Pre-merge author checklist**\r\n\r\n- [ ] I've followed [MetaMask Contributor\r\nDocs](https://github.com/MetaMask/contributor-docs) and [MetaMask\r\nExtension Coding\r\nStandards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).\r\n- [ ] I've completed the PR template to the best of my ability\r\n- [ ] I’ve included tests if applicable\r\n- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format\r\nif applicable\r\n- [ ] I’ve applied the right labels on the PR (see [labeling\r\nguidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).\r\nNot required for external contributors.\r\n\r\n## **Pre-merge reviewer checklist**\r\n\r\n- [ ] I've manually tested the PR (e.g. pull and build branch, run the\r\napp, test code being changed).\r\n- [ ] I confirm that this PR addresses all acceptance criteria described\r\nin the ticket it closes and includes the necessary testing evidence such\r\nas recordings and or screenshots.\r\n\r\n---------\r\n\r\nCo-authored-by: seaona <54408225+seaona@users.noreply.github.com>","shortMessageHtmlLink":"fix: add eth_signTypedData and eth_signTypedData_v3 to `methodsRequir…"}},{"before":"61b53b04db03e78c280f067317e887ecd60bab05","after":"8c69f46c1c943c4f1b5bf6c5558eeb1a829c6c32","ref":"refs/heads/l10n_crowdin_action","pushedAt":"2024-06-28T21:32:44.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"New Crowdin translations by Github Action","shortMessageHtmlLink":"New Crowdin translations by Github Action"}},{"before":"3bbb6eb6608023dd5f435e4480c1cf40a7d60ec5","after":null,"ref":"refs/heads/mb889-bridge-controller","pushedAt":"2024-06-28T21:31:39.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"micaelae","name":null,"path":"/micaelae","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/100321200?s=80&v=4"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEcksU_QA","startCursor":null,"endCursor":null}},"title":"Activity · MetaMask/metamask-extension"}