Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subclasses of OpenGLMobject override pointwise_become_partial() with extra parameters #3805

Open
chopan050 opened this issue Jun 12, 2024 · 0 comments

Comments

@chopan050
Copy link
Contributor

chopan050 commented Jun 12, 2024

Description of bug / unexpected behavior

In the OpenGL side, OpenGLVMobject.pointwise_become_partial()'s signature doesn't match its parents' signature, because it adds an extra parameter remap.

Similarly, OpenGLSurface.pointwise_become_partial()'s signature adds an extra parameter axis. Same with OpenGLTexturedSurface.

This makes CodeQL complain about the signature mismatches.

This doesn't happen in the Cairo side: all signatures match for this method.

Expected behavior

The signatures should match. Either those subclasses should not need extra parameters (the preferred solution), CodeQL should be silenced in that specific case, or the parent class OpenGLMobject should have the option to accept more parameters (not ideal because that causes a divergence from VMobject.pointwise_become_partial()).

How to reproduce the issue

Code for reproducing the problem
Paste your code here.

Additional media files

Images/GIFs

Logs

Terminal output
PASTE HERE OR PROVIDE LINK TO https://pastebin.com/ OR SIMILAR

System specifications

System Details
  • OS (with version, e.g., Windows 10 v2004 or macOS 10.15 (Catalina)):
  • RAM:
  • Python version (python/py/python3 --version):
  • Installed modules (provide output from pip list):
PASTE HERE
LaTeX details
  • LaTeX distribution (e.g. TeX Live 2020):
  • Installed LaTeX packages:

Additional comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant