Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.12 TypeAlias syntax #3772

Open
JasonGrace2282 opened this issue May 20, 2024 · 0 comments
Open

Support Python 3.12 TypeAlias syntax #3772

JasonGrace2282 opened this issue May 20, 2024 · 0 comments
Labels
infrastructure Anything related to our infrastructure

Comments

@JasonGrace2282
Copy link
Contributor

JasonGrace2282 commented May 20, 2024

Python 3.12 introduced some syntax to define TypeAlias's that looks like

type InteralPoint3D = npt.NDArray[ManimPointDType]

Annoyingly for us, this is represented in AST as a TypeAlias node instead of the AnnAssign node we're used to. As such, the autoaliasattr directive does not work with this syntax, and type aliases defined using this syntax are not documented.

While manim still has some time before Python 3.12 becomes the minimum supported version and we can begin using this syntax, it would be nice to have it implemented so that fewer worries occur when that eventually happens.

@JasonGrace2282 JasonGrace2282 added the infrastructure Anything related to our infrastructure label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Anything related to our infrastructure
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant