Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComplexConfiguration doesn't load custom dashboard by default #46

Open
tbeest opened this issue Dec 14, 2023 · 2 comments
Open

ComplexConfiguration doesn't load custom dashboard by default #46

tbeest opened this issue Dec 14, 2023 · 2 comments
Labels

Comments

@tbeest
Copy link

tbeest commented Dec 14, 2023

The ComplexConfiguration VAF example includes a VaultApplication.Dashboard.cs, yet loads the basic Application Name/Version/Publisher text by default.
image

Including the following code within the VaultApplication class will load the dashboard, though I am left to wonder if that is the intended way:

public override string GetDashboardContent(IConfigurationRequestContext context)
{
	return GenerateDashboard();
}

image

@CraigHawker
Copy link
Collaborator

Definitely going to apply the "bug" label to this, as I can't see the reason this would be like this unless it were by accident.

That said: early next year we will be looking at the samples and libraries, so it is possible that we'll fix this as part of that wider work, rather than individually.

It is only a couple of lines as a change though, if someone wants to submit a PR that includes it.

@tbeest
Copy link
Author

tbeest commented Dec 18, 2023

I could submit a PR, but what I wonder if this is the right override to include.
In this forum post you mention that GetStatusDashboardRootItems or GetApplicationOverviewDashboardContent should be overridden, rather than the GetDashboardContent I use above.

As is it is not entirely clear to me which to use when.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants