Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dynamic Icons Colors/Theme not changing after picking new color or theme #4418

Open
Runo888 opened this issue May 25, 2024 · 0 comments
Labels

Comments

@Runo888
Copy link

Runo888 commented May 25, 2024

Describe the bug

First bug report here, excuse me if I do something wrong.

After setting Lawnchair as my default launcher on Pixel 7 with GrapheneOS installed, it seems like changing colors with the color/theme picker does not change the actual icons immediately. This was not a problem before setting Lawnchair as my default launcher, so I don't think this is a problem tied to GrapheneOS.

Additionally, the preview has an odd bug where the selected icon colors are one step behind from the selected option (see the video link below). This was also not present before using Lawnchair as a launcher.

Switching the icon source from within the Lawnchair settings menu appears to correcly update the icons' colors and theme.

Regarding the icons, I'm only using the stock Pixel 7 system icons as well as the Lawnicons app for additional icons. The menu which displays settings for disabling themed icons, enabling them for only the start screen or for both the start screen and app screen seems to make no difference.

There was a similar issue to this (#2882) but that one had been marked as resolved and is one and a half year old. The solution there to use (or at least toggle) "Always Reload Icons" doesn't seem to do anything.

Steps to reproduce

Steps to reproduce the behavior:

  1. Set Lawnchair to be your default launcher
  2. Acquire Lawnicons
  3. Open the pop-up menu, select 'start screen settings'
  4. Select 'general' in the settings menu and scroll down to 'icon style'
  5. Select themed icons to be visible on both the start screen and app screen - the results should be more obvious this way
  6. Close the settings menu and return to the start screen. Open the pop-up menu and select 'background and style'
  7. You should be able to select a number of colors for your icons now. Go ahead and select a few - you'll notice the system's colors will update immediately, but the preview will either show icons with the same colors as before or they will be a step behind your selection
  8. After selecting a color which is different from your original selection, return to the start menu. Notice how the icons are still the original color, despite changing them
  9. Open the 'icon style' menu again from 'start screen settings'
  10. Select Lawnicons, then select the stock icons. Now, if you return to the start screen, the icons will be the correct color

I should mention that this also applies to setting light/dark mode in Lawnchair's settings, and the automatic setting (light at day, dark at night) does not update the icons either.

Expected behavior

  1. The icons' colors update as soon as a new color or theme is selected
  2. The icons in the preview accurately reflect the chosen colors

Screenshots

Something even better: a video

https://file.garden/ZlG3pcqgDit1-6WD/Lawnchair%20Bug%20Themed%20Icons.mp4

In the video I follow some of the steps to reproduce the problem. Notice how the icons start off with a green theming. Then, when I go and adjust the colors, the preview doesn't update correctly - it's one step 'behind' my selection. Finally when I've chosen a different color, I find out the icons have not changed color at all. To fix this, I go into Lawnchair's settings menu and switch between icon packs. This seems to update the icons in a way that corrects their colors.

Device information

  • Device: Google Pixel 7
  • OS: GrapheneOS, Release 2024052100
  • App version: Lawnchair 14 Beta 2

Additional context

No response

@Runo888 Runo888 added the bug label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant