Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modalBehaviors.transitVehicleTypeVOTMultipliers does not behave as expected #3793

Open
wrashid opened this issue Oct 5, 2023 · 0 comments
Open
Labels

Comments

@wrashid
Copy link
Collaborator

wrashid commented Oct 5, 2023

somewhat related issue:
In class PopulationAttributes.scala we only use this parameter, if used by a single mode, however, it could be generalized to multiple modes (not perfect, but better):

        val modeMultiplier = getModeVotMultiplier(Option(embodiedBeamLeg.beamLeg.mode), modeChoiceModel)
        val beamVehicleTypes = embodiedBeamTrip.beamLegs.map(_.mode).toSet.map(mode => TransitVehicleInitializer.transitModeToBeamVehicleType(mode))
        val vehicleTypeVOTMultipliers=beamVehicleTypes.map(beamVehicleTypeId=>modeChoiceModel.transitVehicleTypeVOTMultipliers.getOrElse(beamVehicleTypeId, modeMultiplier))
        val multiplier = vehicleTypeVOTMultipliers.sum / vehicleTypeVOTMultipliers.size
@dimaopen dimaopen added the Bug label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants