Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please add optional plugin kgraphviewerpart to the AppImage #416

Open
GitMensch opened this issue Nov 13, 2022 · 12 comments
Open

please add optional plugin kgraphviewerpart to the AppImage #416

GitMensch opened this issue Nov 13, 2022 · 12 comments

Comments

@GitMensch
Copy link
Contributor

It is totally reasonable to have the minimal AppImage dependencies on the system, in this case: apt install libfuse2 fuse - or manual extraction of the image.

But after doing that and executing either the AppImage and starting hotspot I'm shown:

kf.coreaddons: "Could not find plugin konsolepart"
kf.coreaddons: "Could not find plugin kgraphviewerpart"

It is definitely good to have those dependencies be optional (hotspot starts and works in general) but I'll obviously won't have the full feature set without additional system libraries (and I don't knwo yet how to even get those).

Can you please include these (and possibly more optional) plugins to the AppImage generation?

@milianw
Copy link
Member

milianw commented Nov 13, 2022

yes this is planned to some degree.

konsolepart would dramatically increase the size of the AppImage - I'm unsure if that's worth it.

kgraphviewerpart triggers a crash in libkgraphviewer, which I first have to fix upstream.

@milianw
Copy link
Member

milianw commented Nov 13, 2022

And FTR: all other optional dependencies should already be included, including QCustomPlot and the rust and D demangling support

@GitMensch
Copy link
Contributor Author

Sounds good. As I could not found an issue for that: what is konsolepart used for and how would one install it manually?

@milianw
Copy link
Member

milianw commented Nov 13, 2022

it's used in the record page of hotspot to show CLI output of client applications in a proper way, i.e. including ansi escape sequence highlighting and so forth.

@GitMensch
Copy link
Contributor Author

OK, then other than libkgraphviewer that's completely "optional" and only changes the "beauty" of the output, not lead to a "missing feature" in general. Thanks for that information.

@GitMensch GitMensch changed the title please add optional plugins to the AppImage please add optional plugin kgraphviewerpart to the AppImage Nov 21, 2022
@GitMensch
Copy link
Contributor Author

kgraphviewerpart triggers a crash in libkgraphviewer, which I first have to fix upstream.

Is there an upstream issue to check its status, which you can link to?

@GitMensch
Copy link
Contributor Author

kgraphviewerpart triggers a crash in libkgraphviewer, which I first have to fix upstream.

Is there an upstream issue to check its status, which you can link to?

ping @milianw - this would allow me to properly check upstream

side note as mentioned in #318:

Can you please add docs for this feature? It seems neither the screenshot nor markdown files were adjusted for this after the PR (and both aren't included in the PR either).

@GitMensch

This comment was marked as outdated.

@lievenhey
Copy link
Contributor

still based on KDDW 1.6.
you can see the version in scripts/appimage/Dockerfile

@GitMensch
Copy link
Contributor Author

kgraphviewerpart triggers a crash in libkgraphviewer, which I first have to fix upstream.

Is there an upstream issue to check its status, which you can link to?

ping @milianw - this would allow me to properly check upstream

side note as mentioned in #318:

Can you please add docs for this feature? It seems neither the screenshot nor markdown files were adjusted for this after the PR (and both aren't included in the PR either).

:-) Friendly ping @milianw after a bit more than a year about the upstream issue and the documentation for this feature.

@milianw
Copy link
Member

milianw commented Dec 22, 2023

I don't think there's an upstream issue, and upstream is pretty "dead", meaning we'd have to fix it ourselves. I'm tempted to leave this disabled for now as it's just not working properly and the visualization isn't one I'm missing myself. help welcome!

@GitMensch
Copy link
Contributor Author

If it would really need a fix ourselves - can you please fork upstream in KDAB and create an issue there with the details (how to reproduce whatever issue happens, the known details of the problem, ...)?

This would then allow me to at least inspect it further, possibly fix it and send a PR with a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants