Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for length(wv) #578

Open
davidavdav opened this issue May 11, 2020 · 2 comments · May be fixed by #580
Open

Check for length(wv) #578

davidavdav opened this issue May 11, 2020 · 2 comments · May be fixed by #580

Comments

@davidavdav
Copy link

StatsBase.jl/src/counts.jl

Line 46 in 0ea8e79

length(r) == k || throw(DimensionMismatch())

I think you should check for the length of wv, since you're using @inbounds later
@nalimilan
Copy link
Member

Good catch. Do you feel like making a PR?

@davidavdav
Copy link
Author

OK, done, I saw that there are a few places where <= could be a ≤ and a = could be a in, but this is a different kind of thing...

@nalimilan nalimilan linked a pull request May 18, 2020 that will close this issue
Check for length(wv), fixes #578 #580
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for length(wv), fixes #578 davidavdav/StatsBase.jl
2 participants
@nalimilan @davidavdav