Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion of KShifts and / or Quickshift? #40

Open
rened opened this issue Mar 10, 2015 · 7 comments
Open

Inclusion of KShifts and / or Quickshift? #40

rened opened this issue Mar 10, 2015 · 7 comments
Labels

Comments

@rened
Copy link
Contributor

rened commented Mar 10, 2015

Would there be interest in having https://github.com/rened/KShiftsClustering.jl included here? I have not registered KShiftsClustering with METADATA yet. Or we keep it separate, whatever you think is best.
It is basically a one-iteration kmeans algorithm, similar to self-organizing maps.

@rened rened changed the title Inclusion of KShifts? Inclusion of KShifts and / or Quickshift? Mar 11, 2015
@rened
Copy link
Contributor Author

rened commented Mar 11, 2015

There is now also https://github.com/rened/QuickShiftClustering.jl. Shall it live in a separate package or shall I work on a PR to include it here?

@ViralBShah
Copy link

Ping @johnmyleswhite. It seems to me that it would be a good idea to put energies into one package here.

@johnmyleswhite
Copy link
Member

My concern here is that there is no one who's actively maintaining Clustering, so I'm hesitant to add new functionality.

@rened
Copy link
Contributor Author

rened commented Mar 16, 2015

Then let's keep it separated for now I would propose. We can always revisit this when the future for Clustering.jl is more clear.

@jpfairbanks
Copy link
Contributor

Is there anything worth saving here? Are the interfaces the right way to do it and just the code is rotting?
It looks like the tools for measuring clustering success are useful. I would hate to throw away good code because no one cares to maintain it. If there are better clustering packages, then I would like to know about them.

I am able to help maintain it, although I am not a clustering expert.

@johnmyleswhite
Copy link
Member

Nothing is rotting: the code is completely stable and should not be thrown out.

My point is only that I would like us to stop accruing new features until we start accruing developers that we can trust to take over maintenance of these packages. Adding features is too risky given our labor resources, since we clearly don't have the resources to even respond to the currently open pull requests.

If you have time to review and comment on the existing pull requests, that would be amazing. Once you've done a little bit of maintenance work, I'm happy to give you commit access to this package.

@jpfairbanks
Copy link
Contributor

Ah I misunderstood the situation thanks for giving more detail. I will take
a look at some pull requests and issues.

On Wed, Mar 18, 2015, 12:15 PM John Myles White [email protected]
wrote:

Nothing is rotting: the code is completely stable and should not be thrown
out.

My point is only that I would like us to stop accruing new features until
we start accruing developers that we can trust to take over maintenance of
these packages. Adding features is too risky given our labor resources,
since we clearly don't have the resources to even respond to the currently
open pull requests.

If you have time to review and comment on the existing pull requests, that
would be amazing. Once you've done a little bit of maintenance work, I'm
happy to give you commit access to this package.


Reply to this email directly or view it on GitHub
#40 (comment)
.

@alyst alyst added the feature label Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants