-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TubeSpatialObject bounding box includes rounded ends even after they are turned off #4657
Comments
Thank you for contributing an issue! 🙏 Welcome to the ITK community! 🤗👋☀️ We are glad you are here and appreciate your contribution. Please keep in mind our community participation guidelines. 📜 This is an automatic message. Allow for time for the ITK community to be able to read the issue and comment on it. |
@aylward can you tackle this one? |
It would be very hard (computationally expensive and quirky) to handle all points "near" an end-point as "special." Probably should just document that EndRounded() is always considered True when computing isInside(). More accurately, should remove the "EndRounded()" flag - it is an application/rendering specific option - but that would break backward compatibility. |
Thank you for the prompt responses! I want to note that I am using TubeSpatialObject to describe a simple cylinder. I believe there used to be a CylinderSpatialObject, but was later removed. Considering the backward compatibility, I wonder if it would be easier to reintroduce one (without all the added options for "rounded ends" or "root")? One could even consider this as a base class for TubeSpatialObject. |
Great idea! And much easier to compute flat ends for a cylinder instead
of for a collection of points with arbitrary position and radius per point.
I can create that within a few days. Thanks for the clarifying info!
s
…On Mon, May 13, 2024 at 1:49 PM Ali Uneri ***@***.***> wrote:
Thank you for the prompt responses! I want to note that I am using
TubeSpatialObject to describe a simple cylinder. I believe there used to be
a CylinderSpatialObject, but was later removed. Considering the backward
compatibility, I wonder if it would be easier to reintroduce one (without
all the added options for "rounded ends" or "root")? One could even
consider this as a base class for TubeSpatialObject.
—
Reply to this email directly, view it on GitHub
<#4657 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACEJL6FPNVJ6Q3SMQFTUPTZCD4LPAVCNFSM6AAAAABHS6G4J6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBYGQZDEMBSGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Stephen R. Aylward, Ph.D.
Chair, MONAI Advisory Board
Senior Director, Strategic Initiatives, Kitware
|
Description
The bounding box for TubeSpatialObject always includes rounded ends.
Steps to Reproduce
Expected behavior
Actual behavior
The results do not change when
EndRounded
is toggled, though they should. Moreover, the bounding box extent in z increases whenRadiusInObjectSpace
is increased, which should only be expected whenEndRounded
is True.Reproducibility
Happens every time.
Versions
Tested on v5.3 and v5.4rc4.
Environment
Additional Information
The text was updated successfully, but these errors were encountered: