Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup.py fails to install and missing dependencies #7

Open
ranyishere opened this issue Jan 24, 2021 · 0 comments
Open

Setup.py fails to install and missing dependencies #7

ranyishere opened this issue Jan 24, 2021 · 0 comments
Assignees

Comments

@ranyishere
Copy link

ranyishere commented Jan 24, 2021

System Information

  • Python 3.7.5
  • Linux (debian)
  • 5.4.0-64-generic

Describe the current behavior
Running python setup.py install in a virtual environment fails to install. This is due to errors about install pyrl and version problems with pillow and chardet. After fixing the aforementioned issues, tests fail because of missing pytest dependency.

Describe the expected behavior
Creating a virtual environment and running python setup.py install should work out of the box with no errors. Tests should also work without getting an issue about missing dependency.

Standalone code to reproduce the issue

virtualenv --clear --python=python3.7 venv
source venv/bin/activate
python setup.py install

Below is my fix for the setup.py

from distutils.core import setup

from setuptools import find_packages

opencv_pkg = ""
if "DISPLAY" not in os.environ.keys():
    opencv_pkg = "opencv-python-headless"
else:
    opencv_pkg = "opencv-python"

setup(
    name="vsrl",
    version="0.0.1",
    description="Visceral: A Framework for Verifiably Safe Reinforcement Learning",
    author="IBM Research",
    author_email="[email protected]",
    url="https://visceral.safelearning.ai",
    packages=find_packages(),
    install_requires=[
        "scipy",
        "numpy",
        "torch",
        "pillow==7.2.0",
        "chardet==3.0.4",
        opencv_pkg,
        "pytorch_lightning",
        "comet_ml",
        "psutil",
        "torchvision",
        "parsimonious",
        "matplotlib",
        "portion",
        "toml",
        "auto-argparse",
        "gym",
        "pytest",
    ],
    extras_require={"dev": ["pytest", "pytest-cov"]},
    dependency_links=["http://github.com/astooke/rlpyt/tarball/master"]
)
@nrfulton nrfulton self-assigned this Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants