Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Option to round the bottom corners of view controllers as well? #49

Open
benguild opened this issue Nov 12, 2017 · 1 comment

Comments

@benguild
Copy link

This would come in handy, although should be optional.

@HarshilShah
Copy link
Owner

Hmm, this is a good idea.

However this would require going through quite a bit of the animation/presentation logic, mainly because of nested presentations (presenting a modal with Deck on top of another modal presented with Deck).

These have variable sizes for view controllers, and has potential for conflict since two view controllers might have different preferences re: rounding corners.

I'm focused more on API cleanup for 2.0 right now, will reconsider this after that has shipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants